From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 08/11] Allow for having for_each_ref() list some refs that aren't local
Date: Sat, 08 Mar 2008 19:57:36 -0800 [thread overview]
Message-ID: <7vd4q4sg5r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0803081804170.19665@iabervon.org> (Daniel Barkalow's message of "Sat, 8 Mar 2008 18:04:18 -0500 (EST)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> This is useful, for example, for listing the refs in a reference
> repository during clone, when you don't have your own refs that cover
> the objects that are in your alternate repository.
I hate to ask a question that I myself do not have a good answer to, but
it is a bit worrysome that using these extra refs would cause for-each-ref
to report different refs with the same name (the alternate's master branch
and this one's master branch are both called refs/heads/master).
I think no caller that reads from for_each_ref() keeps track of names that
it has seen and tries clever things like flagging duplicates as errors,
but it still feels like it is inviting trouble.
next prev parent reply other threads:[~2008-03-09 3:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 23:04 [PATCH 08/11] Allow for having for_each_ref() list some refs that aren't local Daniel Barkalow
2008-03-08 23:22 ` Johannes Schindelin
2008-03-08 23:25 ` Daniel Barkalow
2008-03-09 3:57 ` Junio C Hamano [this message]
2008-03-09 6:23 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4q4sg5r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).