git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unused sh functions from git-mergetool.sh
@ 2008-03-03 22:18 Charles Bailey
  2008-03-03 23:33 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Charles Bailey @ 2008-03-03 22:18 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

The tidy up of git mergetool's backup files handling made the two shell
functions save_backup and remove_backup redundant. This commit removes
these now unused functions.

Signed-off-by: Charles Bailey <charles@hashpling.org>
---

This patch belongs on top of the mergetool updates in pu. It removes a
couple of shell functions which were made redundant in commit
6fef6e2...  In fact it should logically be squashed into that commit.


 git-mergetool.sh |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/git-mergetool.sh b/git-mergetool.sh
index d12bedf..5c86f69 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -127,18 +127,6 @@ check_unchanged () {
     fi
 }
 
-save_backup () {
-    if test "$status" -eq 0; then
-	mv -- "$BACKUP" "$MERGED.orig"
-    fi
-}
-
-remove_backup () {
-    if test "$status" -eq 0; then
-	rm "$BACKUP"
-    fi
-}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unused sh functions from git-mergetool.sh
  2008-03-03 22:18 [PATCH] Remove unused sh functions from git-mergetool.sh Charles Bailey
@ 2008-03-03 23:33 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-03-03 23:33 UTC (permalink / raw)
  To: Charles Bailey; +Cc: git

Charles Bailey <charles@hashpling.org> writes:

> This patch belongs on top of the mergetool updates in pu. It removes a
> couple of shell functions which were made redundant in commit
> 6fef6e2...  In fact it should logically be squashed into that commit.

Will do.  Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-03 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-03 22:18 [PATCH] Remove unused sh functions from git-mergetool.sh Charles Bailey
2008-03-03 23:33 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).