From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Don't use GIT_CONFIG in t5505-remote
Date: Wed, 27 Feb 2008 00:21:13 -0800 [thread overview]
Message-ID: <7vd4qix11i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0802261713520.19665@iabervon.org> (Daniel Barkalow's message of "Tue, 26 Feb 2008 17:15:31 -0500 (EST)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> For some reason, t5505-remote was setting GIT_CONFIG to .git/config
> and exporting it. The sole effect of this was to cause the tests to
> fail if "git clone" obeyed it (which it presumably should).
Your patch is correct, as it was a no-op to set and export
GIT_CONFIG to .git/config there as Jeff pointed out.
But I think git-clone should explicitly ignore user-supplied
GIT_CONFIG in the environment if exists, when it wants to update
the configuration file for the new repository it created, as I
mentioned in the other message.
And I think scripted version has the same issue. It would
update random places GIT_CONFIG points at, when it wants to
modify the configuration file for the new repository it just
built, which would be a bug.
prev parent reply other threads:[~2008-02-27 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 22:15 [PATCH] Don't use GIT_CONFIG in t5505-remote Daniel Barkalow
2008-02-26 22:19 ` Jeff King
2008-02-27 8:16 ` Junio C Hamano
2008-02-27 8:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4qix11i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).