From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Clemens Buchacher <drizzd@aon.at>, git@vger.kernel.org
Subject: Re: Built-in checkout: wrong behaviour in subdirectories
Date: Wed, 20 Feb 2008 15:42:52 -0800 [thread overview]
Message-ID: <7vd4qr2o03.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vhcg32p0i.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 20 Feb 2008 15:21:01 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
>> Junio: it looks like something used to cause read-tree to be run with
>> pwd being the working tree root in git-checkout.sh.
>
> "Something"? I think we explicitly cdup when switching
> branches, and we should do the same in C rewrite.
>
> # We are switching branches and checking out trees, so
> # we *NEED* to be at the toplevel.
> cd_to_toplevel
Isn't it just the matter of not passing prefix to topts in
merge_working_tree()? Your other calls to unpack_trees() do not
seem to pass bogus prefix to it.
IIRC, the "prefix" to unpack_trees() is not about the path
limiter, but grafting a tree into a place where it originally
was not intended to be (i.e. to support "read-tree --prefix").
next prev parent reply other threads:[~2008-02-20 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 22:35 Built-in checkout: wrong behaviour in subdirectories Clemens Buchacher
2008-02-20 22:44 ` Daniel Barkalow
2008-02-20 23:21 ` Junio C Hamano
2008-02-20 23:42 ` Junio C Hamano [this message]
2008-02-21 15:50 ` Daniel Barkalow
2008-02-20 23:54 ` [PATCH] checkout: work from a subdirectory Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4qr2o03.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).