From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 1/9] Allow callers of unpack_trees() to handle failure
Date: Tue, 05 Feb 2008 15:43:43 -0800 [thread overview]
Message-ID: <7vd4rb7yvk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LNX.1.00.0802051428180.13593@iabervon.org
Daniel Barkalow <barkalow@iabervon.org> writes:
> On Tue, 5 Feb 2008, Johannes Schindelin wrote:
> ...
>> BTW after the whole series (was too lazy to check the individual
>> patches), I count one instance in builtin-checkout.c and two in diff-lib.c
>> where unpack_trees()' return value is not checked. Is this intended?
>
> ..., but it's probably best to check and
> exit anyway, if only in the conversion commit. (If we remove the check
> afterward, there will be a change in the history that documents that we
> don't need to check)
I think that is a sensible thing to do.
next prev parent reply other threads:[~2008-02-06 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 18:35 [PATCH 1/9] Allow callers of unpack_trees() to handle failure Daniel Barkalow
2008-02-05 1:11 ` Johannes Schindelin
2008-02-05 20:38 ` Daniel Barkalow
2008-02-05 23:43 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-25 23:24 Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4rb7yvk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).