* [PATCH] Remove repo version check from setup_git_directory
@ 2007-12-09 10:14 Nguyễn Thái Ngọc Duy
2007-12-09 10:24 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2007-12-09 10:14 UTC (permalink / raw)
To: git, Junio C Hamano
setup_git_directory_gently has done the check already.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
Sorry, somehow I left this line behind. It should have been gone
from my re-fix patch.
setup.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/setup.c b/setup.c
index e96a316..b59dbe7 100644
--- a/setup.c
+++ b/setup.c
@@ -388,7 +388,6 @@ int check_repository_format(void)
const char *setup_git_directory(void)
{
const char *retval = setup_git_directory_gently(NULL);
- check_repository_format();
/* If the work tree is not the default one, recompute prefix */
if (inside_work_tree < 0) {
--
1.5.3.7.2155.g4c25
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Remove repo version check from setup_git_directory
2007-12-09 10:14 [PATCH] Remove repo version check from setup_git_directory Nguyễn Thái Ngọc Duy
@ 2007-12-09 10:24 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2007-12-09 10:24 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> setup_git_directory_gently has done the check already.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> Sorry, somehow I left this line behind. It should have been gone
> from my re-fix patch.
>
> setup.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/setup.c b/setup.c
> index e96a316..b59dbe7 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -388,7 +388,6 @@ int check_repository_format(void)
> const char *setup_git_directory(void)
> {
> const char *retval = setup_git_directory_gently(NULL);
> - check_repository_format();
Ah, because the previous line already calls the same repository format
check, this is now unneeded, indeed.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-09 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 10:14 [PATCH] Remove repo version check from setup_git_directory Nguyễn Thái Ngọc Duy
2007-12-09 10:24 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).