git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mark Drago <markdrago@gmail.com>
Cc: stelian@popies.net, git@vger.kernel.org
Subject: Re: [PATCH] hg-to-git: handle an empty dir in hg by combining git commits
Date: Sat, 01 Dec 2007 12:02:46 -0800	[thread overview]
Message-ID: <7vd4tq41zt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <4751A0FB.6090705@gmail.com> (Mark Drago's message of "Sat, 01 Dec 2007 12:59:23 -0500")

Mark Drago <markdrago@gmail.com> writes:

> This patch will detect that there are no changes to commit (using git-status),
> and will not perform the commit, but will instead combine the log messages of
> that (non-)commit with the next commit.

I think a better approach would be to implement --no-tree-change-is-ok
option to git-commit, strictly for use by foreign scm interface scripts
like yours.  It does not usually make sense to record a commit that has
the exact same tree as its sole parent commit and that is why git-commit
prevents you from making that mistake, but when data from foreign scm is
involved, it is a different story.  We are equipped to represent such a
(perhaps insane, perhaps by mistake, or perhaps done on purpose) change
and it is better to represent it bypassing the safety valve for native
use.

  reply	other threads:[~2007-12-01 20:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01 17:59 [PATCH] hg-to-git: handle an empty dir in hg by combining git commits Mark Drago
2007-12-01 20:02 ` Junio C Hamano [this message]
2007-12-03  8:44   ` [PATCH] git-commit --allow-empty Junio C Hamano
2007-12-03  8:53     ` Junio C Hamano
2007-12-03 17:58     ` Nicolas Pitre
2007-12-03 18:16       ` Junio C Hamano
2007-12-05  7:01   ` [PATCH] hg-to-git: handle an empty dir in hg by combining git commits Junio C Hamano
2007-12-06 12:50     ` Mark Drago

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4tq41zt.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=markdrago@gmail.com \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).