From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] parseopt: introduce OPT_RECURSE to specify shared options
Date: Mon, 05 Nov 2007 13:48:19 -0800
Message-ID: <7vd4uonz30.fsf@gitster.siamese.dyndns.org>
References: <1194264204-3475-1-git-send-email-madcoder@debian.org>
	<1194264204-3475-2-git-send-email-madcoder@debian.org>
	<Pine.LNX.4.64.0711051230020.4362@racer.site>
	<Pine.LNX.4.64.0711051237420.4362@racer.site>
	<Pine.LNX.4.64.0711051315300.4362@racer.site>
	<Pine.LNX.4.64.0711051340490.4362@racer.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
X-From: git-owner@vger.kernel.org Mon Nov 05 22:49:17 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1Ip9op-000290-MT
	for gcvg-git-2@gmane.org; Mon, 05 Nov 2007 22:49:16 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753845AbXKEVs2 (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 5 Nov 2007 16:48:28 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753855AbXKEVs2
	(ORCPT <rfc822;git-outgoing>); Mon, 5 Nov 2007 16:48:28 -0500
Received: from sceptre.pobox.com ([207.106.133.20]:58857 "EHLO
	sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753509AbXKEVs1 (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 5 Nov 2007 16:48:27 -0500
Received: from sceptre (localhost.localdomain [127.0.0.1])
	by sceptre.pobox.com (Postfix) with ESMTP id CBD762F0;
	Mon,  5 Nov 2007 16:48:46 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 5A34B92922;
	Mon,  5 Nov 2007 16:48:43 -0500 (EST)
In-Reply-To: <Pine.LNX.4.64.0711051340490.4362@racer.site> (Johannes
	Schindelin's message of "Mon, 5 Nov 2007 13:46:20 +0000 (GMT)")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/63564>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> After kicking this around a bit more on IRC, we had another idea.  Instead 
> of introducing OPT_RECURSE(), do something like OPT__QUIET(), only this 
> time in diff.h:
>
> #define OPT__DIFF(opt) \
> 	OPT_BOOLEAN('p', NULL, &opt.format_patch, "show a patch"), \
> 	...
>
> Pierre said this feels a bit "80s", so I'd like to hear other people's 
> opinions.
>
> Hmm?

As I am from "80s" ;-) I like the simpler "macro" one much
better.  There aren't many things that can go wrong in the
approach.