From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] Per-path attribute based hunk header selection.
Date: Sun, 08 Jul 2007 22:05:35 -0700 [thread overview]
Message-ID: <7vd4z2xj34.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0707082320480.26459@xanadu.home> (Nicolas Pitre's message of "Sun, 08 Jul 2007 23:22:41 -0400 (EDT)")
Nicolas Pitre <nico@cam.org> writes:
> On Fri, 6 Jul 2007, Junio C Hamano wrote:
>
>> About the comment from Johannes regarding hunk_header vs
>> funcname, I would actually prefer hunk_header, since that is
>> what this is about ("funcname" and "find_func" were misnomer
>> from the beginning), but I'd rename hunk_header to funcname for
>> the sake of consistency and minimizing the diff.
>
> I think "minimizing the diff" in this case is a bad reason. Using
> hunk_header is so much better than funcname IMHO.
Well, even then it turns out to be a good reason, as the patch
to rename function and field can be a separate patch. After
adding that "latex pattern" stuff, I am even more inclined to
rename them.
next prev parent reply other threads:[~2007-07-09 5:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 18:06 [PATCH 2/2] diff: add custom regular expressions for function names Johannes Schindelin
2007-07-04 18:41 ` Linus Torvalds
2007-07-04 18:45 ` Johannes Schindelin
2007-07-04 20:44 ` Junio C Hamano
2007-07-04 21:20 ` Johannes Schindelin
2007-07-05 5:00 ` Junio C Hamano
2007-07-05 5:02 ` [PATCH 1/2] Future-proof source for changes in xdemitconf_t Junio C Hamano
2007-07-05 11:01 ` Johannes Schindelin
2007-07-05 5:02 ` [PATCH 2/2] WIP per-path attribute based hunk header selection Junio C Hamano
2007-07-05 11:25 ` Johannes Schindelin
2007-07-05 16:43 ` Junio C Hamano
2007-07-06 8:37 ` [PATCH 1/3] Introduce diff_filespec_is_binary() Junio C Hamano
2007-07-06 12:20 ` Johannes Schindelin
2007-07-06 8:39 ` [PATCH] Per-path attribute based hunk header selection Junio C Hamano
2007-07-06 12:38 ` Johannes Schindelin
2007-07-06 17:59 ` Linus Torvalds
2007-07-07 2:00 ` Junio C Hamano
2007-07-07 10:08 ` しらいしななこ
2007-07-07 10:22 ` Junio C Hamano
2007-07-07 12:17 ` Johannes Schindelin
2007-07-07 20:36 ` Junio C Hamano
2007-07-08 7:23 ` Junio C Hamano
2007-07-08 11:58 ` Johannes Schindelin
2007-07-09 3:22 ` Nicolas Pitre
2007-07-09 5:05 ` Junio C Hamano [this message]
2007-07-09 11:40 ` Johannes Schindelin
2007-07-07 10:12 ` [PATCH] Fix configuration syntax to specify customized hunk header patterns Junio C Hamano
2007-07-05 8:24 ` [PATCH 2/2] diff: add custom regular expressions for function names Florian Weimer
2007-07-05 11:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4z2xj34.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).