From: Junio C Hamano <gitster@pobox.com>
To: "Marco Costalba" <mcostalba@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Fix "git log --parent -m" from emitting duplicated parent info
Date: Sun, 08 Jul 2007 17:37:27 -0700 [thread overview]
Message-ID: <7vd4z2za2g.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <e5bfff550707080737j56c161bdrf0c079b61877085b@mail.gmail.com> (Marco Costalba's message of "Sun, 8 Jul 2007 16:37:50 +0200")
This is whitespace damaged in a funny way (some lines do not
have leading whitespace while some do).
log_tree_diff() hence log_tree_commit() is caled by codepaths
other than "git log -p", and I am not convinced that this patch
would not break them. Worrysome.
I wonder why we did not actually remove the duplicate parents
from "commit->parents" list after history simplification when we
originally did 88494239, instead of filtering only on the output
path. Anybody remember the reason?
next prev parent reply other threads:[~2007-07-09 0:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 14:37 [PATCH] Fix "git log --parent -m" from emitting duplicated parent info Marco Costalba
2007-07-08 18:32 ` Junio C Hamano
2007-07-09 0:37 ` Junio C Hamano [this message]
2007-07-09 1:15 ` Johannes Schindelin
2007-07-09 1:28 ` Junio C Hamano
2007-07-09 1:20 ` Junio C Hamano
2007-07-09 1:22 ` Johannes Schindelin
2007-07-09 1:38 ` Junio C Hamano
2007-07-09 5:46 ` Marco Costalba
2007-07-09 6:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4z2za2g.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).