From: Junio C Hamano <junkio@cox.net>
To: Frank Lichtenheld <frank@lichtenheld.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-am: Clean up the asciidoc documentation
Date: Mon, 14 May 2007 17:01:38 -0700 [thread overview]
Message-ID: <7vd513lztp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11791538941022-git-send-email-frank@lichtenheld.de> (Frank Lichtenheld's message of "Mon, 14 May 2007 16:44:53 +0200")
Frank Lichtenheld <frank@lichtenheld.de> writes:
> -i, --interactive::
> - Run interactively, just like git-applymbox.
> + Run interactively, just like `git-applymbox` (see gitlink:git-applymbox[1]).
This is an unclear description from the original, but I think we
should say just like `git-applybox -i`, or drop this altogether.
> @@ -99,7 +102,7 @@ message, and commit author time is taken from the "Date: " line
> of the message. The "Subject: " line is used as the title of
> the commit, after stripping common prefix "[PATCH <anything>]".
> It is supposed to describe what the commit is about concisely as
> -a one line text.
> +an one line text.
I think 'one' does not begin with a vowel.
Other than that, I would agree everything in your update is a
clear improvement.
next prev parent reply other threads:[~2007-05-15 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 14:44 Some misc Documentation patches Frank Lichtenheld
2007-05-14 14:44 ` [PATCH] builtin-log.c: Fix typo in comment Frank Lichtenheld
2007-05-14 14:44 ` [PATCH] Documentation: format-patch has no --mbox option Frank Lichtenheld
2007-05-15 0:03 ` Junio C Hamano
2007-05-15 0:20 ` Junio C Hamano
2007-05-14 14:44 ` [PATCH] git-am: Clean up the asciidoc documentation Frank Lichtenheld
2007-05-15 0:01 ` Junio C Hamano [this message]
2007-05-15 12:23 ` Frank Lichtenheld
2007-05-15 19:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd513lztp.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).