From: Junio C Hamano <junkio@cox.net>
To: Tom Prince <tom.prince@ualberta.net>
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Fix 'crlf' attribute semantics.
Date: Sun, 15 Apr 2007 16:44:00 -0700 [thread overview]
Message-ID: <7vd52519vj.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070415233722.GA20222@hermes> (Tom Prince's message of "Mon, 16 Apr 2007 03:37:22 +0400")
Tom Prince <tom.prince@ualberta.net> writes:
<offtopic>Please do not rudely point other people with
mail-followup-to; I did not want to address this message to
Linus but wanted to talk to YOU specifically, and you stole a
few seconds of my time, forcing me to rewrite my To: line
</offtopic>
> On Sun, Apr 15, 2007 at 04:10:56PM -0700, Junio C Hamano wrote:
>> Earlier we said 'crlf lets the path go through core.autocrlf
>> process while !crlf disables it altogether'. This fixes the
>> semantics to:
>
> This change means there is no way to enable the automatic heuristics for a
> specific pattern once it has been disable for a more generic pattern. Would it
> make sense to make the attributes more than simply boolean?
I do not think that is a problem in practice. Do not set
something to "false" explicitly with a generic pattern, if you
might want to override it.
next prev parent reply other threads:[~2007-04-15 23:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 9:01 [PATCH 1/3] Add basic infrastructure to assign attributes to paths Junio C Hamano
2007-04-13 9:33 ` Andy Parkins
2007-04-15 0:59 ` Junio C Hamano
2007-04-15 1:01 ` [PATCH 1/2] attribute macro support Junio C Hamano
2007-04-15 1:03 ` [PATCH 2/2] Define a few built-in attribute rules Junio C Hamano
2007-04-15 1:41 ` Linus Torvalds
2007-04-15 1:48 ` Brian Gernhardt
2007-04-15 2:04 ` Junio C Hamano
2007-04-15 2:34 ` Junio C Hamano
2007-04-15 16:21 ` Johannes Schindelin
2007-04-15 19:58 ` Junio C Hamano
2007-04-15 4:30 ` Linus Torvalds
2007-04-15 23:10 ` [PATCH] Fix 'crlf' attribute semantics Junio C Hamano
2007-04-15 23:12 ` [PATCH] Fix 'diff' " Junio C Hamano
2007-04-15 23:37 ` [PATCH] Fix 'crlf' " Tom Prince
2007-04-15 23:44 ` Junio C Hamano [this message]
2007-04-16 6:21 ` Raimund Bauer
2007-04-13 15:04 ` [PATCH 1/3] Add basic infrastructure to assign attributes to paths Linus Torvalds
2007-04-15 15:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd52519vj.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=tom.prince@ualberta.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).