From: Junio C Hamano <junkio@cox.net>
To: Matthias Kestenholz <matthias@spinlock.ch>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Adjust reflog filemode in shared repository
Date: Fri, 09 Mar 2007 16:53:50 -0800 [thread overview]
Message-ID: <7vd53h3om9.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11734799371637-git-send-email-matthias@spinlock.ch> (Matthias Kestenholz's message of "Fri, 9 Mar 2007 23:38:57 +0100")
Thanks, will apply to 'maint' to be included in v1.5.0.4 (and
also in 'master' to be in v1.5.1).
We should add tests whenever we found this kind of breakage.
For core.sharedrepository, we would want to have something like
this:
(1) Initialize a repository
(2) set core.sharedrepository
(3) set umask to 077
(4) perform various git operations in the repository
(5) "find .git" to see if there is anything unreadable by group
members; if you find any, you found a bug.
That is the "feature" test -- check if a feature works as
intended.
At the same time, we need to have a corresponding "regression"
test to make sure that a feature does not overstep its boundary
and affect cases where it is not enabled:
(1) Initialize a repository
(2) unset core.sharedrepository
(3) set umask to 077
(4) perform various git operations in the repository
(5) "find .git" to see if there is anything readable by group
members; if you find any, you found a bug.
We would need such "regression" tests for existing tests too,
but that is a separate issue.
prev parent reply other threads:[~2007-03-10 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 22:38 [PATCH] Adjust reflog filemode in shared repository Matthias Kestenholz
2007-03-10 0:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd53h3om9.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=matthias@spinlock.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox