From: Junio C Hamano <junkio@cox.net>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: [BUG] git-fetch -k is broken
Date: Thu, 30 Nov 2006 13:21:59 -0800 [thread overview]
Message-ID: <7vd574iqa0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0611301441440.9647@xanadu.home> (Nicolas Pitre's message of "Thu, 30 Nov 2006 15:11:54 -0500 (EST)")
Nicolas Pitre <nico@cam.org> writes:
> Actually, the .keep file is simply not removed as it should.
>
> But first it appears that commit f64d7fd2 added an && on line 431 of
> git-fetch.sh and that cannot be right. There is simply no condition for
> not removing the lock file. It must be removed regardless if the
> previous command succeeded or not. Junio?
True, but your "echo" patch breaks things even more -- when fast
forward check fails, it should cause the entire command should
report that with the exit status.
That suggests that we need to come up with a way to clean up
these .keep files some other way than just being one of the
command near the end. As to the mysterious "echo e <empty>"
I will not have chance to look at it myself until later today
(I'm at work now and it is not my git day today).
next prev parent reply other threads:[~2006-11-30 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 20:11 [BUG] git-fetch -k is broken Nicolas Pitre
2006-11-30 21:21 ` Junio C Hamano [this message]
2006-12-29 1:41 ` Nicolas Pitre
2006-12-29 2:03 ` Junio C Hamano
2007-01-01 20:42 ` [PATCH] git-fetch: remove .keep file even on other errors Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd574iqa0.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).