git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: tree view: eliminate redundant "blob"
Date: Sun, 01 Oct 2006 11:56:27 -0700	[thread overview]
Message-ID: <7vd59b27c4.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200610012041.15296.jnareb@gmail.com> (Jakub Narebski's message of "Sun, 1 Oct 2006 20:41:14 +0200")

Jakub Narebski <jnareb@gmail.com> writes:

> ... That means that we cannot distinguish really well (at 
> least color) between tree and blob entries.

Do we even say links are blue and underlined by forcing that in
our css?

Doesn't leading drwxr-xr-x mean anything?

Why is making the distinction important in the first place?

> In the case of shortlog/log/history/heads/tags view, to clearly mark 
> subject/title of a commit or tag as link, we would have to use default 
> link decoration....
> But underlined text is harder to read, and blue underlined text even 
> more so...

This is something in which I can see some more sense than tree
vs blob issue, but only as a principle issue.  In practice, the
list of commit subjects is the first thing users encounter, and
as long as there is some visual indication (e.g. mousing over it
makes it obvious it is something that is clickable), I think
users will quickly pick up that it will lead to the commit's
detail.

  reply	other threads:[~2006-10-01 18:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26  5:38 [PATCH] gitweb: tree view: eliminate redundant "blob" Luben Tuikov
2006-09-26  6:34 ` Junio C Hamano
2006-09-26 17:04   ` Luben Tuikov
2006-09-26  8:54 ` Jakub Narebski
2006-09-26  9:22   ` Jakub Narebski
2006-09-26 16:07   ` Petr Baudis
2006-09-26 16:24     ` Jakub Narebski
2006-09-26 20:33     ` Luben Tuikov
2006-09-27  2:40     ` Junio C Hamano
2006-10-01 18:49       ` Jakub Narebski
2006-09-26 20:14   ` Luben Tuikov
2006-09-26 20:31     ` Jakub Narebski
2006-09-26 21:32       ` Luben Tuikov
2006-09-26 22:24         ` Jakub Narebski
2006-09-26 22:30           ` Jakub Narebski
2006-09-27  6:42         ` Junio C Hamano
2006-10-01 18:41           ` Jakub Narebski
2006-10-01 18:56             ` Junio C Hamano [this message]
2006-10-01 19:27               ` Jakub Narebski
2006-10-02  7:15                 ` Andreas Ericsson
2006-10-02 10:56                   ` Jakub Narebski
2006-10-02  7:34               ` Junio C Hamano
2006-10-02 11:06                 ` Jakub Narebski
2006-10-02 19:46               ` Luben Tuikov
2006-10-02 19:11             ` Luben Tuikov
2006-10-02 20:03               ` Jakub Narebski
2006-10-03  4:14                 ` Junio C Hamano
2006-10-03  8:18                   ` Jakub Narebski
2006-10-03  9:34                     ` Junio C Hamano
2006-10-03 10:15                       ` Jakub Narebski
2006-10-05  0:15                       ` Luben Tuikov
2006-10-03 20:20                     ` Luben Tuikov
2006-10-03 16:31                   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd59b27c4.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).