From: Junio C Hamano <junkio@cox.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix fetch completeness assumptions
Date: Thu, 15 Sep 2005 01:09:25 -0700 [thread overview]
Message-ID: <7vd5naah1m.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0509142120020.23242@iabervon.org> (Daniel Barkalow's message of "Wed, 14 Sep 2005 21:31:42 -0400 (EDT)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> Don't assume that any commit we have is complete; assume that any ref
> we have is complete.
>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
>
> ---
> Only lightly tested, but it seems to work. Marks all of the commits in
> refs, and their ancestors back as far as the date of the commit it's
> processing. If the commit it's processing is marked, it doesn't recurse
> into it.
First I thought you were using the date for the cutting-off
decision and was going to object to the patch because of it, but
re-reading the code made me realize that you are using date only
to better the heuristics that limits how many commits reachable
from existing refs we would tangle to see if the newly seen
commit is reachable from our refs -- the logic looks correct.
The "complete" commit_list is a clever piece of code; I like it.
next prev parent reply other threads:[~2005-09-15 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 1:31 [PATCH] Fix fetch completeness assumptions Daniel Barkalow
2005-09-15 8:09 ` Junio C Hamano [this message]
2005-09-15 16:42 ` Daniel Barkalow
2005-09-15 11:02 ` Sergey Vlasov
2005-09-15 16:54 ` Daniel Barkalow
2005-09-16 6:04 ` Junio C Hamano
2005-09-17 8:02 ` Junio C Hamano
2005-09-17 8:32 ` Junio C Hamano
2005-09-17 8:50 ` Help cloning over http Junio C Hamano
2005-09-17 17:37 ` Daniel Barkalow
2005-09-18 17:38 ` [PATCH] Improve the safety check used in fetch.c Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd5naah1m.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).