* [PATCH] commit: Fix a memory leak in determine_author_info
@ 2013-07-14 14:01 Stefan Beller
2013-07-15 14:42 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Beller @ 2013-07-14 14:01 UTC (permalink / raw)
To: git; +Cc: Stefan Beller
The date variable is assigned new memory via xmemdupz and 2 lines later
it is assigned new memory again via xmalloc, but the first assignment
is never freed nor used.
---
builtin/commit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 790e5ab..00da83c 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf *author_ident)
(lb - strlen(" ") -
(a + strlen("\nauthor "))));
email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
- date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
len = eol - (rb + strlen("> "));
date = xmalloc(len + 2);
*date = '@';
--
1.8.3.2.806.gdee5b9b
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] commit: Fix a memory leak in determine_author_info
2013-07-14 14:01 [PATCH] commit: Fix a memory leak in determine_author_info Stefan Beller
@ 2013-07-15 14:42 ` Junio C Hamano
2013-07-15 14:46 ` Stefan Beller
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2013-07-15 14:42 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
Stefan Beller <stefanbeller@googlemail.com> writes:
> The date variable is assigned new memory via xmemdupz and 2 lines later
> it is assigned new memory again via xmalloc, but the first assignment
> is never freed nor used.
> ---
> builtin/commit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 790e5ab..00da83c 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf *author_ident)
> (lb - strlen(" ") -
> (a + strlen("\nauthor "))));
> email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
> - date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
> len = eol - (rb + strlen("> "));
> date = xmalloc(len + 2);
> *date = '@';
Makes sense. I'd assume this is signed-off?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] commit: Fix a memory leak in determine_author_info
2013-07-15 14:42 ` Junio C Hamano
@ 2013-07-15 14:46 ` Stefan Beller
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Beller @ 2013-07-15 14:46 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On 07/15/2013 04:42 PM, Junio C Hamano wrote:
> Stefan Beller <stefanbeller@googlemail.com> writes:
>
>> The date variable is assigned new memory via xmemdupz and 2 lines later
>> it is assigned new memory again via xmalloc, but the first assignment
>> is never freed nor used.
>> ---
>> builtin/commit.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/builtin/commit.c b/builtin/commit.c
>> index 790e5ab..00da83c 100644
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf *author_ident)
>> (lb - strlen(" ") -
>> (a + strlen("\nauthor "))));
>> email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
>> - date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
>> len = eol - (rb + strlen("> "));
>> date = xmalloc(len + 2);
>> *date = '@';
>
> Makes sense. I'd assume this is signed-off?
>
As I realised I did not sign it,
I resend it with some other findings a few hours later,
so you'll find it there as well.
See Message-ID
<1373837749-14402-2-git-send-email-stefanbeller@googlemail.com>
[PATCH 2/4] commit: Fix a memory leak in determine_author_info
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-15 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-14 14:01 [PATCH] commit: Fix a memory leak in determine_author_info Stefan Beller
2013-07-15 14:42 ` Junio C Hamano
2013-07-15 14:46 ` Stefan Beller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).