git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] am: handle stray $dotest directory
Date: Fri, 14 Jun 2013 10:20:47 -0700	[thread overview]
Message-ID: <7vehc4pq1c.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALkWK0n+KSrehL3tZ557c2hfKna6p_jVGL+a2az5V+h4=DstJQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Fri, 14 Jun 2013 21:45:24 +0530")

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Junio C Hamano wrote:
>> The reason would become clear once you think what string you are
>> feeding eval_gettext with if you do not escape.  The translators
>> translate a fixed string (possibly with placeholders) to a fixed
>> translated string (possibly with placeholders).
>>
>>         eval_gettext "Stray $dotest directory found. ..."
>>
>> would allow the shell to expand $dotest before eval_gettext sees it,
>> which would mean the string is no longer a constant.
>
> Ah.  I was scratching my head wondering why $dotest needed to be
> translated (it's just a path).

"Stray" and "directory found" are to be translated.  You can have
infinite possibilities to $dotest that is computed at runtime, so
that should be kept as a variable, untranslated in the message
template.

  reply	other threads:[~2013-06-14 17:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  7:47 [PATCH v2 0/2] Fix am with stray $dotest directory Ramkumar Ramachandra
2013-06-14  7:47 ` [PATCH 1/2] am: handle " Ramkumar Ramachandra
2013-06-14 15:06   ` Junio C Hamano
2013-06-14 15:11     ` Ramkumar Ramachandra
2013-06-16  6:36       ` Ramkumar Ramachandra
2013-06-14 15:17     ` Junio C Hamano
2013-06-14 16:13       ` Ramkumar Ramachandra
2013-06-14 17:09         ` Junio C Hamano
2013-06-14 19:00           ` Junio C Hamano
2013-06-15 12:35             ` Ramkumar Ramachandra
2013-06-14 15:08   ` Junio C Hamano
2013-06-14 15:11     ` Ramkumar Ramachandra
2013-06-14 15:19       ` Junio C Hamano
2013-06-14 16:15         ` Ramkumar Ramachandra
2013-06-14 17:20           ` Junio C Hamano [this message]
2013-06-14  7:47 ` [PATCH 2/2] t/am: use test_path_is_missing() where appropriate Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vehc4pq1c.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).