git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH] format-patch: remove existing output-directory
Date: Fri, 14 Jun 2013 06:58:34 -0700	[thread overview]
Message-ID: <7vehc4ssj9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130614132102.GG23890@serenity.lan> (John Keeping's message of "Fri, 14 Jun 2013 14:21:02 +0100")

John Keeping <john@keeping.me.uk> writes:

> On Fri, Jun 14, 2013 at 06:45:19PM +0530, Ramkumar Ramachandra wrote:
>> John Keeping wrote:
>> > I don't think this is the correct behaviour.  I can think of cases where
>> > I would want to output multiple things into the same directory.
>> 
>> format.cleanOutputDirectory = true|false?
>
> Maybe, but I was thinking of something more like:
>
>     Output directory is not empty, use "--allow-non-empty-dir" if you
>     really want to proceed.
>
> Using that configuration variable lets someone shoot themselves in the
> foot quite badly if they forget that they have set it and set the output
> directory to somewhere containing important data.

Yes.  format.refuseToOutputToNonEmpty that defaults to false and
gives your error message is a sensible way to go.

  reply	other threads:[~2013-06-14 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 12:43 [PATCH] format-patch: remove existing output-directory Ramkumar Ramachandra
2013-06-14 13:10 ` John Keeping
2013-06-14 13:15   ` Ramkumar Ramachandra
2013-06-14 13:21     ` John Keeping
2013-06-14 13:58       ` Junio C Hamano [this message]
2013-06-14 13:55   ` Junio C Hamano
2013-06-14 13:16 ` Fredrik Gustafsson
2013-06-14 13:34   ` Ramkumar Ramachandra
2013-06-14 13:48     ` Fredrik Gustafsson
2013-06-14 13:52       ` Ramkumar Ramachandra
2013-06-14 13:50     ` SZEDER Gábor
2013-06-14 13:51       ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vehc4ssj9.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).