From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>, Max Horn <max@quendi.de>
Subject: Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output
Date: Tue, 02 Apr 2013 12:58:38 -0700 [thread overview]
Message-ID: <7vehesd7rl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1364929382-1399-8-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Tue, 2 Apr 2013 13:02:56 -0600")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> We can't use stdout for that in remote helpers.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
You may want to clarify "buggy output" a bit. Will mercurial
forever be broken? Some versions of Hg emit [[[it is unclear for
Junio to tell what it is to fill this blank]]] to its output that
we want to ignore?
> contrib/remote-helpers/git-remote-hg | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index b200e60..874ccd4 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -271,6 +271,7 @@ def get_repo(url, alias):
>
> myui = ui.ui()
> myui.setconfig('ui', 'interactive', 'off')
> + myui.fout = sys.stderr
>
> if hg.islocal(url):
> repo = hg.repository(myui, url)
next prev parent reply other threads:[~2013-04-02 19:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 19:02 [PATCH 00/13] remote-hg: general updates Felipe Contreras
2013-04-02 19:02 ` [PATCH 01/13] remote-hg: trivial cleanups Felipe Contreras
2013-04-02 19:02 ` [PATCH 02/13] remote-hg: add missing config variable in doc Felipe Contreras
2013-04-02 19:02 ` [PATCH 03/13] remote-hg: properly report errors on bookmark pushes Felipe Contreras
2013-04-02 19:02 ` [PATCH 04/13] remote-hg: fix for files with spaces Felipe Contreras
2013-04-02 19:02 ` [PATCH 05/13] remote-hg: make sure fake bookmarks are updated Felipe Contreras
2013-04-02 19:02 ` [PATCH 06/13] remote-hg: trivial test cleanups Felipe Contreras
2013-04-02 19:02 ` [PATCH 07/13] remote-hg: redirect buggy mercurial output Felipe Contreras
2013-04-02 19:58 ` Junio C Hamano [this message]
2013-04-02 20:22 ` Felipe Contreras
2013-04-02 20:36 ` Junio C Hamano
2013-04-04 15:07 ` Felipe Contreras
2013-04-04 16:29 ` Junio C Hamano
2013-04-02 19:02 ` [PATCH 08/13] remote-hg: split bookmark handling Felipe Contreras
2013-04-02 19:02 ` [PATCH 09/13] remote-hg: refactor export Felipe Contreras
2013-04-02 19:02 ` [PATCH 10/13] remote-hg: update remote bookmarks Felipe Contreras
2013-04-02 19:03 ` [PATCH 11/13] remote-hg: force remote push Felipe Contreras
2013-04-02 19:03 ` [PATCH 12/13] remote-hg: don't update bookmarks unnecessarily Felipe Contreras
2013-04-02 19:03 ` [PATCH 13/13] remote-hg: update tags globally Felipe Contreras
2013-04-02 19:55 ` [PATCH 00/13] remote-hg: general updates Junio C Hamano
2013-04-02 20:27 ` Felipe Contreras
2013-04-02 20:47 ` Junio C Hamano
2013-04-02 20:09 ` John Keeping
2013-04-02 22:23 ` Max Horn
2013-04-03 1:31 ` Felipe Contreras
2013-04-03 9:20 ` Felipe Contreras
2013-04-03 9:23 ` Antoine Pelisse
2013-04-05 8:26 ` Felipe Contreras
2013-04-04 0:25 ` Max Horn
2013-04-04 6:42 ` Felipe Contreras
2013-04-04 6:46 ` Felipe Contreras
2013-04-04 9:07 ` Max Horn
2013-04-04 9:35 ` Felipe Contreras
2013-04-05 22:30 ` Max Horn
2013-04-06 0:45 ` Felipe Contreras
2013-04-06 14:09 ` Philip Oakley
2013-04-06 16:01 ` Felipe Contreras
2013-04-06 1:28 ` Junio C Hamano
2013-04-06 1:47 ` Felipe Contreras
2013-04-07 3:32 ` Junio C Hamano
2013-04-04 18:11 ` Jed Brown
2013-04-04 18:34 ` Junio C Hamano
2013-04-04 19:23 ` Jed Brown
2013-04-04 19:45 ` Felipe Contreras
2013-04-04 18:41 ` Felipe Contreras
2013-04-04 19:01 ` Jed Brown
2013-04-04 16:14 ` Felipe Contreras
2013-04-05 11:45 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vehesd7rl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).