Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
	Erik Faye-Lund <kusmabite@gmail.com>,
	David Wade <DAWAD@statoil.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Is this a bug?
Date: Fri, 22 Feb 2013 13:48:46 -0800	[thread overview]
Message-ID: <7vehg8c94x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABURp0rO5zJywFN16=Sn20b2DAVA7XBs4EC4GxGbxftXqUS6gA@mail.gmail.com> (Phil Hord's message of "Fri, 22 Feb 2013 14:29:47 -0500")

Phil Hord <phil.hord@gmail.com> writes:

> Or maybe --amend should imply --cleanup=whitespace.

I am fairly negative on that.

Such a hidden linkage, even if it is documented, is just one more
thing people need to learn.

It _might_ be interesting (note: I did not say "worthwhile" here) to
think what happens if we scanned the message (either coming from the
commit being amended, -F file option, or -m message option), picked
a punctuation character that does not appear at the beginning of the
lines in it, and automatically adjusted core.commentchar if '#'
appears at the beginning of one of the lines, though.

      reply	other threads:[~2013-02-22 21:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19  9:32 Is this a bug? David Wade
2013-02-19  9:42 ` Andreas Ericsson
2013-02-19  9:47 ` Erik Faye-Lund
2013-02-19 11:02   ` Duy Nguyen
2013-02-22 19:29     ` Phil Hord
2013-02-22 21:48       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vehg8c94x.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=DAWAD@statoil.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox