From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>,
"Jiang Xin" <worldhello.net@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð" <avarab@gmail.com>,
"Nguyễn Thái Ngọc" <pclouds@gmail.com>,
"Jay Soffian" <jaysoffian@gmail.com>
Subject: Re: [PATCH v3 6/7] Remove unused and bad gettext block from git-am
Date: Tue, 24 Jul 2012 15:18:46 -0700 [thread overview]
Message-ID: <7veho0erax.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120724212506.GA15798@burratino> (Jonathan Nieder's message of "Tue, 24 Jul 2012 16:25:06 -0500")
Jonathan Nieder <jrnieder@gmail.com> writes:
> I guess that means the intended justification is the following?
>
> The git am -d/--dotest option has errored out with a message
> since e72c7406 (am: remove support for -d .dotest, 2008-03-04).
> The error message about lack of support was eliminated along
> with other cleanups (probably by mistake) a year later by
> removing the option from the option table in 98ef23b3 (git-am:
> minor cleanups, 2009-01-28).
>
> But the code to handle -d and --dotest stayed around even though
> ever since then it could not be tripped. Remove this dead code.
>
> Noticed because the error message starts with a '-' and
> xgettext does not cope well with that.
Looks good.
next prev parent reply other threads:[~2012-07-24 22:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 6:59 [PATCH v3 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-24 6:59 ` [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-24 6:59 ` [PATCH v3 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-24 6:59 ` [PATCH v3 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-24 6:59 ` [PATCH v3 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-24 6:59 ` [PATCH v3 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-24 6:59 ` [PATCH v3 6/7] Remove unused and bad gettext block from git-am Jiang Xin
2012-07-24 6:59 ` [PATCH v3 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-24 9:47 ` Stefano Lattarini
2012-07-24 18:27 ` [PATCH v3 6/7] Remove unused and bad gettext block from git-am Jonathan Nieder
2012-07-24 20:40 ` Junio C Hamano
2012-07-24 21:16 ` Martin von Zweigbergk
2012-07-24 21:21 ` Junio C Hamano
2012-07-24 21:25 ` Jonathan Nieder
2012-07-24 22:18 ` Junio C Hamano [this message]
2012-07-24 18:16 ` [PATCH v3 5/7] i18n: am: mark more strings for translation Jonathan Nieder
2012-07-24 20:43 ` Junio C Hamano
2012-07-25 6:38 ` Thomas Rast
2012-07-24 23:00 ` Jiang Xin
2012-07-24 18:08 ` [PATCH v3 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jonathan Nieder
2012-07-24 19:07 ` Junio C Hamano
2012-07-24 9:44 ` [PATCH v3 3/7] i18n: Rewrite gettext messages start with dash Stefano Lattarini
2012-07-24 9:43 ` [PATCH v3 2/7] i18n: rebase: mark strings for translation Stefano Lattarini
2012-07-24 18:01 ` Jonathan Nieder
2012-07-24 18:57 ` Junio C Hamano
2012-07-24 22:49 ` Jiang Xin
2012-07-24 9:38 ` [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh Stefano Lattarini
2012-07-24 17:46 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veho0erax.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=jrnieder@gmail.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=pclouds@gmail.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).