From: Junio C Hamano <gitster@pobox.com>
To: Leila <muhtasib@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-status: Show empty directories
Date: Mon, 11 Jun 2012 09:57:23 -0700 [thread overview]
Message-ID: <7vehpl7pn0.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAA3EhHLWDtUeNB+RZA064Omwxh7SEYhSc53U0nuiSTNzioKnug@mail.gmail.com> (Leila's message of "Sun, 10 Jun 2012 12:02:39 -0400")
Leila <muhtasib@gmail.com> writes:
>> Having said all that, I personally doubt this is a useful change. I
>> may have thought of adding a README file to a relatively new project that
>> does not yet have one while in shower but I haven't even created the
>> file in the working tree. And I forget about it once I get to the
>> office. Should the system remind me to create README and then add?
>> Your patch would not give me such a reminder once the top-level
>> directory is populated (because it is no longer empty). Even if I
>> were planning to add Documentation/README instead, I would get such
>> a reminder only if the Documentation directory is empty. Once the
>> directory is populated, I wouldn't get "create README and then add".
>> Why should an empty directory so special?
>
> So there are two separate discussions here:
> 1) Should empty dirs be tracked
>
> 2) Should empty dirs appear under 'untracked' in git status
You are not answering my question by asking either these two
questions.
Please read what you quoted again. I may have forgotten to create
and add README
- at the toplevel directory; or
- in the Documentation directory that already has other tracked
files; or
- in the Documentation directory that does not have any file yet.
Why do I get a reminder for only the last case? Also please realize
that at no point in the scenario I am interested in adding an empty
directory. "How does one add empty directories" is irrelevant to my
question.
A more reasonable answer would have been "the reminder is not about
a yet-to-be-created README file, but is about an empty directory you
might have wanted to place something---there is no way for Git to
guess that you wanted the new file to be README, but at least having
a totally empty directory laying around may be an indication that
you wanted to do something intereseting in it but haven't yet". If
the proposed commit log message justified the behaviour to treat
only the third one specially that way, I suspect it may make some
sense.
next prev parent reply other threads:[~2012-06-11 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 19:40 [PATCH] git-status: Show empty directories Leila Muhtasib
2012-06-09 20:13 ` konglu
2012-06-09 21:08 ` Leila
2012-06-09 21:14 ` Thomas Rast
2012-06-09 21:24 ` Leila
2012-06-09 21:47 ` konglu
2012-06-10 9:01 ` Thomas Rast
2012-06-10 9:46 ` konglu
2012-06-10 14:20 ` Leila
2012-06-11 15:08 ` Junio C Hamano
2012-06-10 7:15 ` Junio C Hamano
2012-06-10 16:02 ` Leila
2012-06-10 18:12 ` konglu
2012-06-10 18:17 ` Leila
2012-06-11 16:57 ` Junio C Hamano [this message]
2012-06-11 18:51 ` Leila
2012-06-11 19:00 ` Leila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vehpl7pn0.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=muhtasib@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).