From: Junio C Hamano <gitster@pobox.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: Jeff King <peff@peff.net>, Clemens Buchacher <drizzd@aon.at>,
dfowler <davidfowl@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
Paul Betts <paul@github.com>, David Ebbo <david.ebbo@gmail.com>
Subject: Re: [PATCH 3/3] t5541: test more combinations of --progress
Date: Tue, 01 May 2012 13:53:06 -0700 [thread overview]
Message-ID: <7vehr38vyl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4FA04B4C.4090507@in.waw.pl> ("Zbigniew Jędrzejewski-Szmek"'s message of "Tue, 01 May 2012 22:45:00 +0200")
Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
>> +test_expect_success 'push --progress shows progress to non-tty' '
>> + cd "$ROOT_PATH"/test_repo_clone &&
>> + test_commit progress &&
>> + git push --progress 2>&1 | tee output &&
>> + grep "^To http" output &&
>> + grep "^Writing objects" output
>> +'
>> +
> I understand that test_i18ngrep is not necessary, because pack-objects.c
> is not internationalized. But wouldn't it make sense to use
> test_i18ngrep in preparation, so that tests don't have to be modified
> later on?
In this test, we are not interested in making sure the progress output is
properly localized. I'd rather see it keep using grep and if you really
care, run "git push" under "LANG=C LC_ALL=C" or something reliable instead.
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-05-01 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120501010609.GA14715@jupiter.local>
2012-05-01 6:58 ` 1.7.10 doesn't show file pushstatus Jeff King
2012-05-01 7:33 ` Jeff King
2012-05-01 8:40 ` Jeff King
2012-05-01 8:41 ` [PATCH 1/3] send-pack: show progress when isatty(2) Jeff King
2012-05-01 8:42 ` [PATCH 2/3] teach send-pack about --[no-]progress Jeff King
2012-05-01 8:43 ` [PATCH 3/3] t5541: test more combinations of --progress Jeff King
2012-05-01 9:35 ` Clemens Buchacher
2012-05-01 9:37 ` Jeff King
2012-05-01 17:53 ` David Ebbo
2012-05-01 20:45 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 20:53 ` Junio C Hamano [this message]
2012-05-01 9:32 ` 1.7.10 doesn't show file pushstatus Clemens Buchacher
2012-05-01 17:33 ` Junio C Hamano
2012-05-02 1:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vehr38vyl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=david.ebbo@gmail.com \
--cc=davidfowl@gmail.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=paul@github.com \
--cc=peff@peff.net \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).