From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Vincent van Ravesteijn <vfr@lyx.org>,
git@vger.kernel.org, martin.von.zweigbergk@gmail.com
Subject: Re: [PATCH] Documentation/git-rerere: document 'remaining' command
Date: Thu, 08 Mar 2012 14:30:00 -0800 [thread overview]
Message-ID: <7veht2buaf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABURp0pd4wAw0ax5jjaoOR-bAWUGUQa-k1xby9_Bb_wQwsLk7w@mail.gmail.com> (Phil Hord's message of "Thu, 8 Mar 2012 16:08:50 -0500")
Phil Hord <phil.hord@gmail.com> writes:
> On Thu, Mar 8, 2012 at 12:23 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Phil Hord <phil.hord@gmail.com> writes:
> ...
> $ git rebase origin/master
> Noise, noise, noise
> Resolved 'foo' using previous resolution.
> Failed to merge in the changes.
>
> I reach for my utility belt, but my usual tricks all fail at this point:
>
> $ git mergetool
> No files need merging
>
> $ git rebase --continue
> foo: needs merge
Just to make sure we are on the same page (I do not personally use
"mergetool"), the above looks like a bug in mergetool.
Are you reporting a still-unfixed breakage, or is it an anecdote on
how you were frustrated in the past due to a bug that has since been
fixed?
> How's this:
Looks good.
> 'status'::
>
> -Like 'diff', but this only prints the filenames that will be tracked
> -for resolutions.
> +Print paths with conflicts whose merge resolution rerere will record.
> +
> +'remaining'::
> +
> +Print paths with conflicts that have not been autoresolved by rerere.
> +This includes paths whose resolutions cannot be tracked by rerere,
> +such as conflicting submodules.
We might want to add "and a path that was deleted by one branch and
modified by the other branch" at the end here.
Unless an earlier part of the documentation that discusses what kind
of resolutions get recorded and reapplied makes it clear enough that
the reader can easily guess a delete/modify conflict is not handled,
that is. I _think_ the description at the top makes it clear the
two branches being merged both need to have a file at the path, so
in that sense, singling out delete/modify and mentioning it here
might be redundant, but I am not the target audience (I wrote and
named it rerere after all ;-), so I shouldn't be my own judge.
Thanks.
prev parent reply other threads:[~2012-03-08 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:21 [PATCH] Documentation/git-rerere: document 'remaining' command Vincent van Ravesteijn
2012-03-06 19:24 ` Junio C Hamano
2012-03-07 22:10 ` Phil Hord
2012-03-07 22:24 ` Junio C Hamano
2012-03-08 3:08 ` Phil Hord
2012-03-08 5:23 ` Junio C Hamano
2012-03-08 21:08 ` Phil Hord
2012-03-08 22:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veht2buaf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.von.zweigbergk@gmail.com \
--cc=phil.hord@gmail.com \
--cc=vfr@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).