Re: [PATCH v2 1/2] grep: add option to show whole function as context

[Junio C Hamano <gitster@pobox.com>]

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Add a new option, -W, to show the whole surrounding function of a match.

Thanks, will queue both patches.

It feels somewhat dirty to take the range between the previous "funcname"
and the next "funcname" and consider it the whole function, as if there is
nothing outside the function, though. I certainly understand that this is
a natural and unfortunate consequence that "funcname" is a mechanism
designed to mark only the _beginning_, and we didn't have any need for a
mechanism to mark the _end_.

I am not complaining; just making an observation.  I do not offhand have a
suggestion for improving this, and I think the obvious "then let's come up
with another configuration to mark the end" is not an improvement but
making things worse, so...