git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>, drizzd@aon.at
Subject: Re: [PATCH] t3419-*.sh: Fix arithmetic expansion syntax error
Date: Tue, 21 Dec 2010 12:24:39 -0800	[thread overview]
Message-ID: <7vei9a98mw.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4D10F707.1000206@ramsay1.demon.co.uk> (Ramsay Jones's message of "Tue\, 21 Dec 2010 18\:50\:47 +0000")

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> Note that this test is unique in having an '#!/bin/bash' line (rather
> than '#!/bin/sh'),...

Thanks for spotting, and that is idiotic for us to have such a script.
We should fix the shebang line as well.

A quick git-grep shows that this is the only instance of this problem
(outside contrib/completion/git-completion.bash, that is).

  reply	other threads:[~2010-12-21 20:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21 18:50 [PATCH] t3419-*.sh: Fix arithmetic expansion syntax error Ramsay Jones
2010-12-21 20:24 ` Junio C Hamano [this message]
2010-12-22 18:42 ` Clemens Buchacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vei9a98mw.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).