From: Junio C Hamano <gitster@pobox.com>
To: "R. Tyler Ballance" <tyler@monkeypox.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Correct references to /usr/bin/python which does not exist on FreeBSD
Date: Sun, 21 Mar 2010 15:13:21 -0700 [thread overview]
Message-ID: <7veijdfhmm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100321212335.GB32016@kiwi.sharlinx.com> (R. Tyler Ballance's message of "Sun\, 21 Mar 2010 14\:23\:35 -0700")
"R. Tyler Ballance" <tyler@monkeypox.org> writes:
>> I would have expected that the patch would look more like this:
>> ...
>> What am I missing?
>
> No, that looks right, I didn't notice the specialized section towards the
> bottom for FreeBSD or the others for that matter.
Thanks. I usually use a "make" wrapper to handle platform particulars
like setting PYTHON_PATH automatically outside of the build system we
ship, and never noticed this.
I'll just commit my version with a forged sign-off from you ;-)
next prev parent reply other threads:[~2010-03-21 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 19:01 [PATCH v2] Correct references to /usr/bin/python which does not exist on FreeBSD R. Tyler Ballance
2010-03-21 21:15 ` Junio C Hamano
2010-03-21 21:23 ` R. Tyler Ballance
2010-03-21 22:13 ` Junio C Hamano [this message]
2010-03-21 23:00 ` R. Tyler Ballance
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veijdfhmm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tyler@monkeypox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).