From: Junio C Hamano <gitster@pobox.com>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: Evan Farrer <evan.farrer@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH/RFC] Add support for the google-chrome web browser
Date: Tue, 05 Jan 2010 11:56:40 -0800 [thread overview]
Message-ID: <7veim4xr47.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <32541b131001051056o5853b1d2xd57d75d9a62f9f1a@mail.gmail.com> (Avery Pennarun's message of "Tue\, 5 Jan 2010 13\:56\:13 -0500")
Avery Pennarun <apenwarr@gmail.com> writes:
> The current behaviour will barf right away (I think) because it
> doesn't know. If it instead had a default case that just assumed
> non-firefox behaviour, then it would fail *strangely* (instead of
> predictably) on browsers that needed special workarounds, such as an
> as-yet-unknown firefox derivative.
Ok, I can buy that.
I have a feeling that extensibility situation of this script is similar to
that of mergetool/difftool. Perhaps a similar approach to refactor and
then support browser-specific peculiarities by separate files, outlined in
http://thread.gmane.org/gmane.comp.version-control.git/134906/focus=135006
might work well, don't you think?
prev parent reply other threads:[~2010-01-05 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 5:19 [PATCH/RFC] Add support for the google-chrome web browser Evan Farrer
2010-01-05 5:40 ` Junio C Hamano
2010-01-05 17:20 ` Avery Pennarun
2010-01-05 18:39 ` Junio C Hamano
2010-01-05 18:56 ` Avery Pennarun
2010-01-05 19:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veim4xr47.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apenwarr@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=evan.farrer@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).