From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christian Couder <chriscool@tuxfamily.org>, git@vger.kernel.org
Subject: Re: [RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option
Date: Wed, 04 Nov 2009 11:22:04 -0800 [thread overview]
Message-ID: <7veioegko3.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.01.0911041033530.31845@localhost.localdomain> (Linus Torvalds's message of "Wed\, 4 Nov 2009 10\:35\:47 -0800 \(PST\)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Wed, 4 Nov 2009, Linus Torvalds wrote:
>>
>> Yes, it is a behavioral change, but is it a bad one?
>
> .. and perhaps we could introduce --bisect-refs as the "old behavior" of
> '--bisect' to git rev-list?
>
> I kind of suspect that it is unlikely that people are using 'git rev-list
> --bisect' while _inside_ a bisection, but then wanting to bisect someting
> that is outside the set of commits we're currently actively bisecting.
>
> But maybe I'm wrong.
Maybe I'm wrong too, but I do not think that is plausible that people are
doing nested bisection that way. It is probably a useful thing to do, but
if somebody has thought of doing so we would have at least seen a request
to add a way to tell "git-bisect" what names to use to record the good/bad
set of commits under to make their implementation easier. I haven't, and
I take it an indication that it is very implausible that such scripts by
people exist to be broken by this change.
I was more worried about people who reinvented the wheel and are using
their own git-bisect.sh derivative. It probably was forked from the
version that still used 'git rev-list --bisect", manually feeding good and
bad set of commits to it from the command line. But then what they are
feeding would be the same as the new --bisect option implicitly gives them
anyway, so there won't be a regression either.
next prev parent reply other threads:[~2009-11-04 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 4:00 [RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option Christian Couder
2009-11-04 4:00 ` [RFC/PATCH 1/3] t6030: show "rev-list --bisect" breakage when bisecting Christian Couder
2009-11-04 4:00 ` [RFC/PATCH 2/3] revision: change '--bisect' rev machinery argument to 'bisect-refs' Christian Couder
2009-11-04 4:00 ` [RFC/PATCH 3/3] bisect: simplify calling visualizer using '--bisect-refs' Christian Couder
2009-11-04 18:25 ` [RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option Junio C Hamano
2009-11-04 18:32 ` Linus Torvalds
2009-11-04 18:35 ` Linus Torvalds
2009-11-04 19:22 ` Junio C Hamano [this message]
2009-11-04 21:26 ` Christian Couder
2009-11-04 21:52 ` Junio C Hamano
2009-11-05 5:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veioegko3.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).