From: Junio C Hamano <gitster@pobox.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-tag(1): Refer to git-check-ref-format(1) for <name>
Date: Mon, 03 Aug 2009 23:20:20 -0700 [thread overview]
Message-ID: <7veirs6qxn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87ab2gsqst.fsf@jondo.cante.net> (Jari Aalto's message of "Mon\, 03 Aug 2009 21\:20\:02 +0300")
Jari Aalto <jari.aalto@cante.net> writes:
> Explain briefly what characters are prohibited in tag <name>
> and point to git-check-ref-format(1) manual page for
> more information.
> ---
Thanks.
I do not see a reason to reject this patch (other than lack of sign-off),
but at the same time, I wish if we can somehow teach people that the
branches and the tags are just two special cases of refs that follow
exactly the same set of rules, we would not have to apply another similar
patch to git-branch documentation and instead we can teach what the naming
rules are for refs in general. Then the readers can learn the rule once,
and extend the knowledge to other types of refs (e.g. notes) in the
future.
I however do not think of a way to organize our documentations without too
many levels of indirections (e.g. repeating "X is just a ref and for
naming rules, see check-ref-format(1)" for all types X of refs). Not
repeating the rules for documentation of each kind of ref will make the
maintenance a lot easier but hurts readability, but the set of rules is
not a large enough to justify the complexity to use a separate include
file at the source level.
next prev parent reply other threads:[~2009-08-04 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 18:20 [PATCH] git-tag(1): Refer to git-check-ref-format(1) for <name> Jari Aalto
2009-08-04 6:20 ` Junio C Hamano [this message]
2009-08-05 21:20 ` Jari Aalto
2009-08-22 0:45 ` Nanako Shiraishi
2009-08-25 8:21 ` Nanako Shiraishi
2009-08-25 20:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veirs6qxn.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).