git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
	John Tapsell <johnflux@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors
Date: Fri, 10 Apr 2009 17:52:47 -0700	[thread overview]
Message-ID: <7veiw0nh9c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090410093436.6117@nanako3.lavabit.com

Nanako Shiraishi <nanako3@lavabit.com> writes:

> Quoting Christian Couder:
>
>> When doing:
>> 
>> eval "git rev-list --bisect-vars ..." | {
>>         while read line
>>         do
>>                 echo "$line &&"
>>         done
>>         echo ':'
>> }
>> 
>> the result code comes from the last "echo ':'", not from running
>> "git rev-list --bisect-vars ...".
>> 
>> This means that we may miss errors from "git rev-list".
>> 
>> To fix that, this patch gets rid of the pipes by redirecting the
>> output of "git rev-list" into a file, and then reading from this
>> file.
>> 
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> Junio, may I ask what happened to this patch?

I've chosen to ignore it, hoping that Christian's other bisect topic to
stabilize soon.  That will make this patch unnecessary, I think.

      reply	other threads:[~2009-04-11  0:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29  9:58 [PATCH] bisect: avoid pipes to better catch "git rev-list" errors Christian Couder
2009-04-10  0:34 ` Nanako Shiraishi
2009-04-11  0:52   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7veiw0nh9c.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=johnflux@gmail.com \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).