From: Junio C Hamano <gitster@pobox.com>
To: markus.heidelberg@web.de
Cc: David Aguilar <davvid@gmail.com>,
Jay Soffian <jaysoffian@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] contrib/difftool: use a separate config namespace for difftool commands
Date: Tue, 17 Mar 2009 16:42:10 -0700 [thread overview]
Message-ID: <7veiwvpvhp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200903172054.46063.markus.heidelberg@web.de> (Markus Heidelberg's message of "Tue, 17 Mar 2009 20:54:45 +0100")
Markus Heidelberg <markus.heidelberg@web.de> writes:
> David Aguilar, 10.03.2009:
>> On 0, Jay Soffian <jaysoffian@gmail.com> wrote:
>> > On Mon, Mar 9, 2009 at 5:12 AM, David Aguilar <davvid@gmail.com> wrote:
>> > > contrib/difftool/git-difftool | 6 +++---
>> >
>> > Aside, (for Junio I guess...), what's the reason this command is in
>> > contrib, and by what criteria might it graduate to being installed
>> > with the rest of the git commands?
>> >
>> > j.
>>
>> My thoughts (also for Junio, I guess..):
>>
>> If y'all feel that it can live with the rest of the git
>> commands then that would be great =)
>
> I'd like to see it as a general git tool, too.
> Maybe it can even share some common functionality with git-mergetool.
The code was copied and pasted very heavily, and I think (IIRC) the author
was a bit too ashamed to have it outside contrib/ before it is properly
refactored or something like that. Which I happen to agree with, by the
way.
next prev parent reply other threads:[~2009-03-17 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 9:12 [PATCH] contrib/difftool: use a separate config namespace for difftool commands David Aguilar
2009-03-09 15:52 ` Jay Soffian
2009-03-10 7:01 ` David Aguilar
2009-03-17 19:54 ` Markus Heidelberg
2009-03-17 23:42 ` Junio C Hamano [this message]
2009-03-18 4:35 ` David Aguilar
2009-03-18 10:53 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veiwvpvhp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).