From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: John Tapsell <johnflux@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Make the 'lock file exists' error more informative
Date: Wed, 04 Mar 2009 09:55:12 -0800 [thread overview]
Message-ID: <7veixd5g1r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <vpqvdqpb7w6.fsf@bauges.imag.fr> (Matthieu Moy's message of "Wed, 04 Mar 2009 16:54:49 +0100")
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> John Tapsell <johnflux@gmail.com> writes:
>
>> It looks like someone did 90% of the work, then forgot to actually use
>> the function
>
> someone = me ;-).
>
> The message is a bit inacurrate: the function is already used in two
> places, I just didn't notice this one.
>
>> - if (errno == EEXIST) {
>> + if (err == EEXIST) {
>
> Oops, right.
>
>> - die("unable to create '%s.lock': %s", path, strerror(errno));
>> + unable_to_lock_index_die(path, errno);
>
> Actually, _this_ instance is still to be fixed in next. You probably
> looked at the other one that my original message fixes.
Not in 'next', but in the maintenance track of v1.6.2.X and merged
upwards, as v1.6.2~11^2~2 (More friendly message when locking the index
fails., 2009-02-19) is obviously in v1.6.2 just released.
John, congratulations for fixing the first bug immediately after a big
release. Please make it a habit to sign off your patches.
next prev parent reply other threads:[~2009-03-04 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 15:07 [PATCH] Make the 'lock file exists' error more informative John Tapsell
2009-03-04 15:18 ` John Tapsell
2009-03-04 15:54 ` Matthieu Moy
2009-03-04 17:55 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-04 15:00 [PATCH] Make the 'lock file' exists " John Tapsell
2009-03-04 15:03 ` John Tapsell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veixd5g1r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).