From: Junio C Hamano <gitster@pobox.com>
To: John Tapsell <johnflux@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
"Peter Valdemar Mørch (Lists)" <4ux6as402@sneakemail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: clarify how -S works
Date: Tue, 03 Mar 2009 10:24:28 -0800 [thread overview]
Message-ID: <7veixebh2b.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <43d8ce650903030939u73f09171uf4041b6d9824b698@mail.gmail.com> (John Tapsell's message of "Tue, 3 Mar 2009 17:39:38 +0000")
John Tapsell <johnflux@gmail.com> writes:
> 2009/3/3 Jeff King <peff@peff.net>:
>> On Tue, Mar 03, 2009 at 08:42:12AM -0800, Junio C Hamano wrote:
>>
>>> In retrospect, because --pickaxe was designed primarily for Porcelain use,
>>> it was a mistake for it to have taken a short-and-sweet -S synonym.
>>
>> Hmm. I actually like the pickaxe behavior and find it useful for
>> searching. IOW, I consider it a porcelain feature, just perhaps not the
>> one that some people are expecting.
>>
>>> > -S<string>::
>>> > - Look for differences that contain the change in <string>.
>>> > + Look for differences that introduce or remove an instance of
>>> > + <string>. Note that this is different than the string simply
>>> > + appearing in diff output; see the 'pickaxe' entry in
>>> > + linkgit:gitdiffcore[7] for more details.
>>>
>>> Look for differences that change the number of occurrences of <string>?
>>
>> Yes, that is technically correct. I was trying to find a wording that
>> was a little less "this is literally what it does" and more "this is
>> what you might find it useful for".
>
> Is there any way to have an option to also match any line containing
> the string?
Patches welcome. I've already outlined what you need to do.
I think it can be called -G (short for --grep-diff), if --search cannot be
used because "-s" is unavailable.
next prev parent reply other threads:[~2009-03-03 18:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 14:28 git log -Sfoo ignores indentation (whitespace?) changes "Peter Valdemar Mørch (Lists)"
2009-03-03 15:23 ` Jeff King
2009-03-03 15:40 ` [PATCH] doc: clarify how -S works Jeff King
2009-03-03 16:12 ` John Tapsell
2009-03-03 16:19 ` Jeff King
2009-03-03 16:22 ` John Tapsell
2009-03-03 16:42 ` Junio C Hamano
2009-03-03 17:11 ` Jeff King
2009-03-03 17:39 ` John Tapsell
2009-03-03 17:57 ` Jeff King
2009-03-03 18:24 ` Junio C Hamano [this message]
2009-03-03 15:48 ` git log -Sfoo ignores indentation (whitespace?) changes "Peter Valdemar Mørch (Lists)"
2009-03-03 16:03 ` Jeff King
2009-03-03 16:21 ` Junio C Hamano
2009-03-03 16:02 ` Michael J Gruber
2009-03-03 16:25 ` Jeff King
2009-03-03 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veixebh2b.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=4ux6as402@sneakemail.com \
--cc=git@vger.kernel.org \
--cc=johnflux@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).