git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: respect in-reply-to regardless of threading
Date: Mon, 02 Mar 2009 23:16:11 -0800	[thread overview]
Message-ID: <7veixfgjpg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <74fdbb84d14a6d39f1b61e18ab9588ca08926292.1235947339.git.trast@student.ethz.ch> (Thomas Rast's message of "Sun, 1 Mar 2009 23:45:41 +0100")

Thomas Rast <trast@student.ethz.ch> writes:

> git-send-email supports the --in-reply-to option even with
> --no-thread.  However, the code that adds the relevant mail headers
> was guarded by a test for --thread.
>
> Remove the test, so that the user's choice is respected.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Thomas Rast wrote:
>> But it also turns out, as you can see, that git-send-email happily
>> ignores --in-reply-to if threading is disabled. :-(
>
> This is the minimally intrusive fix.  It would be more consistent to
> ask for the in-reply-to regardless of thread setting, but it would
> also be less of a fix and more of a behaviour change.

I agree.  Tests?

  reply	other threads:[~2009-03-03  7:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-01 21:24 [PATCH 2/2 RFC] fetch-pack: log(n)-transmission find_common() Thomas Rast
2009-03-01 21:37 ` Thomas Rast
2009-03-01 22:45   ` [PATCH] send-email: respect in-reply-to regardless of threading Thomas Rast
2009-03-03  7:16     ` Junio C Hamano [this message]
2009-03-02  7:37   ` [PATCH 2/2 RFC] fetch-pack: log(n)-transmission find_common() Junio C Hamano
2009-03-01 21:39 ` [PATCH 1/2] fetch-pack: rearrange main loop Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7veixfgjpg.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).