From: Junio C Hamano <gitster@pobox.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE
Date: Sat, 07 Feb 2009 11:43:41 -0800 [thread overview]
Message-ID: <7veiyavxqq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <498DA4F9.20104@gmail.com> (Tay Ray Chuan's message of "Sat, 07 Feb 2009 23:12:57 +0800")
Tay Ray Chuan <rctay89@gmail.com> writes:
> In 753bc91 ("Remove the requirement opaquelocktoken uri scheme"), the
> lock token is guaranteed to be prefixed with the string
> 'opaquelocktoken:', which propagated down to file path creation
> operations in the remote repository, namely, in start_put (and
> consequently start_move).
>
> These file operations may not be successful, due to the colon ':'
> character in the file path (specifically, in Windows).
>
> This patch ensures that the lock token sans 'opaquelocktoken:' is used
> instead in start_put.
I am not familiar with DAV so I have to wonder who guarantees in the
codepath that the string that follows the "opaquelocktoken:" (and any
other lock token uri scheme) is without problematic characters, such as a
slash (or colon)?
prev parent reply other threads:[~2009-02-07 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 15:12 [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE Tay Ray Chuan
2009-02-07 17:03 ` Johannes Schindelin
2009-02-07 17:52 ` Tay Ray Chuan
2009-02-07 18:04 ` Johannes Schindelin
2009-02-07 18:38 ` Tay Ray Chuan
2009-02-07 18:57 ` Johannes Schindelin
2009-02-07 19:00 ` Tay Ray Chuan
2009-02-07 19:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veiyavxqq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).