git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: Funny: git -p submodule summary
Date: Fri, 09 Jan 2009 01:30:23 -0800	[thread overview]
Message-ID: <7veizc25e8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090109083836.GB21389@coredump.intra.peff.net> (Jeff King's message of "Fri, 9 Jan 2009 03:38:36 -0500")

Jeff King <peff@peff.net> writes:

> So the _real_ problem is that we are not always triggering the "wait for
> pager to finish" code because we exec and forget about it. Which means
> this strategy of "git runs child pager" will never work properly.
> Instead, we have to use three processes: git and the pager become child
> processes, while the original process waits for both to exit and returns
> the proper exit code from git.
>
> Let me try to work up a patch.

This arrangement to have the third process could even open the possibility
of having it read from git and write to pager, and not launching the pager
if there is no interesting data from git to feed it with.

I do not know if I like the performance implications associated with it,
though.

  parent reply	other threads:[~2009-01-09  9:31 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 15:07 Funny: git -p submodule summary Johannes Schindelin
2009-01-08 15:30 ` Johannes Schindelin
2009-01-09  8:38 ` Jeff King
2009-01-09  9:22   ` Jeff King
2009-01-09  9:48     ` Jeff King
2009-01-09 10:09     ` Johannes Sixt
2009-01-09 10:13       ` Jeff King
2009-01-09 10:36         ` Johannes Sixt
2009-01-09 10:47           ` Jeff King
2009-01-11 11:22           ` Jeff King
2009-01-11 11:25             ` [PATCH 1/4] Makefile: clean up TEST_PROGRAMS definition Jeff King
2009-01-11 11:32             ` [PATCH 2/4] chain kill signals for cleanup functions Jeff King
2009-01-11 11:40               ` Jeff King
2009-01-11 11:36             ` [PATCH 3/4] refactor signal handling " Jeff King
2009-01-11 11:36             ` [PATCH 4/4] pager: do wait_for_pager on signal death Jeff King
2009-01-11 21:13               ` Junio C Hamano
2009-01-12 10:59             ` Funny: git -p submodule summary Johannes Sixt
2009-01-12 11:21               ` Jeff King
2009-01-12 12:00                 ` Johannes Sixt
2009-01-12 12:03                   ` Jeff King
2009-01-12 12:19                     ` Johannes Sixt
2009-01-09  9:30   ` Junio C Hamano [this message]
2009-01-09  9:33     ` Jeff King
2009-01-09  9:38       ` Junio C Hamano
2009-01-27  6:25 ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Jeff King
2009-01-27  6:26   ` [RFC/PATCH 1/3] git: s/run_command/run_builtin/ Jeff King
2009-01-27  6:27   ` [RFC/PATCH 2/3] run_command: handle missing command errors more gracefully Jeff King
2009-01-27  6:27   ` [RFC/PATCH 3/3] git: use run_command to execute dashed externals Jeff King
2009-01-27 10:06   ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Johannes Sixt
2009-01-27 12:23     ` Jeff King
2009-01-27 12:46       ` Johannes Sixt
2009-01-28  7:17         ` Jeff King
2009-01-27 16:31   ` Johannes Schindelin
2009-01-28  7:30     ` Jeff King
2009-01-28  7:33       ` [PATCHv2 1/4] git: s/run_command/run_builtin/ Jeff King
2009-01-28  7:35       ` [PATCHv2 2/4] run_command: handle missing command errors more gracefully Jeff King
2009-01-28  7:36       ` [PATCHv2 3/4] run-command: help callers distinguish errors Jeff King
2009-01-28  7:43         ` Jeff King
2009-01-28  7:47           ` Jeff King
2009-01-28  7:38       ` [PATCHv2 4/4] git: use run_command to execute dashed externals Jeff King
2009-01-28  7:54       ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7veizc25e8.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).