From: Junio C Hamano <gitster@pobox.com>
To: "Santi Béjar" <santi@agolina.net>
Cc: "Jeff King" <peff@peff.net>, "Git Mailing List" <git@vger.kernel.org>
Subject: Re: git commit -v does not removes the patch
Date: Mon, 10 Nov 2008 15:27:18 -0800 [thread overview]
Message-ID: <7vej1j40x5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <adf1fd3d0811101434j658b2e8aj83d8cbe2293f5021@mail.gmail.com> (Santi Béjar's message of "Mon, 10 Nov 2008 23:34:51 +0100")
"Santi Béjar" <santi@agolina.net> writes:
> On Mon, Nov 10, 2008 at 7:10 PM, Jeff King <peff@peff.net> wrote:
>> On Mon, Nov 10, 2008 at 04:20:51PM +0100, Santi Béjar wrote:
>>
>>> Hi *,
>>>
>>> $subject since:
>>>
>>> 4f672ad (wt-status: load diff ui config, 2008-10-26)
>>>
>>> I tried to make a test case, but failed. I think because it is a bit
>>> tricky the fake_editor/stdin/stdout stuff, so at the end I bisected it
>>> by hand
>>
>> Sorry, I don't quite understand what the problem is. From reading your
>> subject line, I expected that "git commit -v" would show the diff in
>> your editor, but then accidentally also include it in the final commit
>> message. But I can't seem to reproduce that.
>>
>> Can you describe the problem in more detail?
>
> It is exactly as you described. I'll try in other systems.
Guess in the dark... by any chance are you enabling color unconditionally?
next prev parent reply other threads:[~2008-11-10 23:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 15:20 git commit -v does not removes the patch Santi Béjar
2008-11-10 18:10 ` Jeff King
2008-11-10 22:34 ` Santi Béjar
2008-11-10 23:27 ` Junio C Hamano [this message]
2008-11-11 0:07 ` Jeff King
2008-11-11 7:56 ` Santi Béjar
2008-11-11 10:29 ` Jeff King
2008-11-11 11:20 ` Santi Béjar
2008-11-11 17:13 ` Junio C Hamano
2008-11-12 8:16 ` Jeff King
2008-11-12 8:17 ` [PATCH 1/5] define empty tree sha1 as a macro Jeff King
2008-11-12 8:21 ` [PATCH 2/5] wt-status: refactor initial commit printing Jeff King
2008-11-12 8:23 ` [PATCH 3/5] status: show "-v" diff even for initial commit Jeff King
2008-11-12 8:24 ` [PATCH 4/5] commit: loosen pattern for matching "-v" diff Jeff King
2008-11-12 8:25 ` [PATCH 5/5] commit: only strip diff from message in verbose mode Jeff King
2008-11-12 8:29 ` Jeff King
2008-11-13 2:15 ` git commit -v does not removes the patch Junio C Hamano
2008-11-20 13:09 ` SZEDER Gábor
2008-11-20 15:20 ` Jeff King
2008-11-22 15:55 ` SZEDER Gábor
2008-11-22 20:10 ` Jeff King
2008-11-22 22:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej1j40x5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).