From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] git send-email: allow any rev-list option as an argument.
Date: Mon, 03 Nov 2008 17:04:27 -0800 [thread overview]
Message-ID: <7vej1sti78.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081103091513.GC13930@artemis.corp> (Pierre Habouzit's message of "Mon, 03 Nov 2008 10:15:13 +0100")
Pierre Habouzit <madcoder@debian.org> writes:
> As a summary, I'd say that I like both (1) and (3) because those are
> handy, short, and either completely or mostly backward compatible. My
> way would be to go down (1) and add a alias.s-e = !git send-email -F in
> my .gitconfig.
>
> What do you think ?
I wonder if we can do this even without an explicit -F.
What command line arguments does send-email take, and what options would
we want to give the underlying format-patch? Can't you sift them without
ambiguity?
The current syntax is:
git send-email <flags>... <file|dir>...
I am wondering if we can just extend it to:
git send-email <flags>... <<file|dir>...|rev>
E.g. we should be able to parse this out:
git send-email --to git@vger.kernel.org -M --suppress-cc=all origin
and notice "--to git@vger.kernel.org" and "--suppress-cc" are for
send-email, guess "-M" (or anything that is outside the current
send-email's vocabulary) is meant for format-patch, and if there is no
file or directory called "origin" then decide that the user wants to run
format-patch, and act as a front-end as if the user did:
git format-patch -o tmp.$$ -M origin &&
... perhaps do your --annotate and --compose here by launching
... the editor...
git send-email --to git@vger.kernel.org --suppress-cc=all tmp.$$ &&
rm -fr tmp.$$
If you happen to have a file or a directory called origin, it would be
safer for users if the command errored out asking for disambiguation. The
user can either say "./origin" or "origin^0" to disambiguate between them.
Hmm?
next prev parent reply other threads:[~2008-11-04 1:06 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 10:57 git send-email improvements Pierre Habouzit
2008-10-31 10:57 ` [PATCH 1/3] git send-email: avoid leaking directory file descriptors Pierre Habouzit
2008-10-31 10:57 ` [PATCH 2/3] git send-email: interpret unknown files as revision lists Pierre Habouzit
2008-10-31 10:57 ` [PATCH 3/3] git send-email: add --annotate option Pierre Habouzit
2008-10-31 21:34 ` Ian Hilt
2008-11-02 6:23 ` Junio C Hamano
2008-11-02 9:51 ` Pierre Habouzit
2008-11-03 12:18 ` Matthieu Moy
2008-10-31 16:52 ` [PATCH] git send-email: allow any rev-list option as an argument Pierre Habouzit
2008-11-02 4:35 ` Jeff King
2008-11-02 9:39 ` Pierre Habouzit
2008-11-02 18:02 ` Jeff King
2008-11-03 9:15 ` Pierre Habouzit
2008-11-04 1:04 ` Junio C Hamano [this message]
2008-11-04 8:19 ` Pierre Habouzit
2008-11-02 4:31 ` [PATCH 1/3] git send-email: avoid leaking directory file descriptors Jeff King
2008-10-31 12:36 ` Further enhancement proposal for git-send-email Pierre Habouzit
2008-10-31 12:36 ` [PATCH 1/3] git send-email: make the message file name more specific Pierre Habouzit
2008-10-31 12:36 ` [PATCH 2/3] git send-email: do not ask questions when --compose is used Pierre Habouzit
2008-10-31 12:36 ` [PATCH 3/3] git send-email: turn --compose on when more than one patch Pierre Habouzit
2008-10-31 21:33 ` [PATCH 2/3] git send-email: do not ask questions when --compose is used Ian Hilt
2008-10-31 21:38 ` Pierre Habouzit
2008-10-31 22:01 ` Ian Hilt
2008-11-01 2:26 ` Ian Hilt
2008-11-01 11:04 ` Pierre Habouzit
2008-11-01 13:00 ` Ian Hilt
2008-11-01 17:08 ` Pierre Habouzit
2008-11-01 17:34 ` Francis Galiegue
2008-11-01 17:43 ` Pierre Habouzit
2008-11-01 19:56 ` Francis Galiegue
2008-11-01 17:54 ` Ian Hilt
2008-11-02 6:18 ` [PATCH 1/3] git send-email: make the message file name more specific Junio C Hamano
2008-11-02 9:35 ` Pierre Habouzit
2008-11-02 21:34 ` Ian Hilt
2008-11-03 8:53 ` Pierre Habouzit
2008-11-04 16:24 ` [take 2] git send-email updates Pierre Habouzit
2008-11-04 16:24 ` [PATCH 1/5] git send-email: make the message file name more specific Pierre Habouzit
2008-11-04 16:24 ` [PATCH 2/5] git send-email: interpret unknown files as revision lists Pierre Habouzit
2008-11-04 16:24 ` [PATCH 3/5] git send-email: add --annotate option Pierre Habouzit
2008-11-04 16:24 ` [PATCH 4/5] git send-email: ask less questions when --compose is used Pierre Habouzit
2008-11-04 16:24 ` [PATCH 5/5] git send-email: turn --compose on when more than one patch Pierre Habouzit
2008-11-04 23:54 ` Junio C Hamano
2008-11-05 3:31 ` Jeff King
2008-11-05 7:03 ` Junio C Hamano
2008-11-05 10:40 ` [PATCH 2/5] git send-email: interpret unknown files as revision lists Pierre Habouzit
2008-11-05 15:17 ` Junio C Hamano
2008-11-09 18:56 ` Junio C Hamano
2008-11-04 20:09 ` [PATCH 4/5] git send-email: ask less questions when --compose is used Francis Galiegue
2008-11-04 23:54 ` Junio C Hamano
2008-11-04 23:54 ` [PATCH 2/5] git send-email: interpret unknown files as revision lists Junio C Hamano
2008-11-10 23:53 ` [take 2] git send-email updates Pierre Habouzit
2008-11-10 23:53 ` [PATCH 1/4] git send-email: make the message file name more specific Pierre Habouzit
2008-11-10 23:54 ` [PATCH 2/4] git send-email: interpret unknown files as revision lists Pierre Habouzit
2008-11-10 23:54 ` [PATCH 3/4] git send-email: add --annotate option Pierre Habouzit
2008-11-10 23:54 ` [PATCH 4/4] git send-email: ask less questions when --compose is used Pierre Habouzit
2008-11-12 5:48 ` [PATCH 2/4] git send-email: interpret unknown files as revision lists Junio C Hamano
2008-11-11 20:30 ` [take 2] git send-email updates Junio C Hamano
2008-11-11 22:13 ` Pierre Habouzit
2008-11-12 0:14 ` Junio C Hamano
2008-11-13 0:01 ` Re* " Junio C Hamano
2008-11-15 22:07 ` Pierre Habouzit
2008-11-15 22:05 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej1sti78.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).