From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Alex Riesen <raa.lkml@gmail.com>,
Pierre Habouzit <madcoder@debian.org>,
git@vger.kernel.org
Subject: Re: [PATCH] prepare deprecation of git-revert
Date: Fri, 31 Oct 2008 16:20:24 -0700 [thread overview]
Message-ID: <7vej1w73nr.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0811010012320.22125@pacific.mpi-cbg.de.mpi-cbg.de> (Johannes Schindelin's message of "Sat, 1 Nov 2008 00:13:29 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Fri, 31 Oct 2008, Alex Riesen wrote:
>
>> Pierre Habouzit, Fri, Oct 31, 2008 16:55:27 +0100:
>> > @@ -439,16 +436,17 @@ static int revert_or_cherry_pick(int argc, const char **argv)
>> >
>> > int cmd_revert(int argc, const char **argv, const char *prefix)
>> > {
>> > +#if 0
>> > + warning("git revert is deprecated, please use git cherry-pick --revert/-R instead");
>> > +#endif
>>
>> "git revert" is much shorter to type than "git cherry-pick -R". How
>> about renaming "cherry-pick" into something short, like "pick"?
>
> I thought we agreed that we should _never_ remove support for "git
> revert"? I mean, we can deprecate it, but I find it pretty strong, and
> unnecessary, to break existing users' expectations.
Likewise.
The current state of affairs is that there is no remedy if teachers find
"git checkout -- path" or "git revert HEAD~24" is confusing to new people.
By introducing "git unstage path" or "git cherry-pick -r HEAD~24",
teachers can choose to teach what they feel less confusing, and they do
not have to teach "git checkout -- path" or "git revert HEAD~24". We
should stop there.
next prev parent reply other threads:[~2008-10-31 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 15:55 [PATCH] prepare deprecation of git-revert Pierre Habouzit
2008-10-31 15:57 ` Pierre Habouzit
2008-10-31 16:36 ` Jakub Narebski
2008-10-31 16:54 ` Pierre Habouzit
2008-10-31 19:01 ` Theodore Tso
2008-11-01 11:53 ` Andreas Ericsson
2008-10-31 16:50 ` Alex Riesen
2008-10-31 16:58 ` Pierre Habouzit
2008-10-31 23:24 ` Alex Riesen
2008-10-31 23:13 ` Johannes Schindelin
2008-10-31 23:20 ` Junio C Hamano [this message]
2008-11-01 23:01 ` Matthieu Moy
2008-11-02 9:32 ` Nguyen Thai Ngoc Duy
2008-11-02 16:12 ` Johannes Schindelin
2008-11-02 4:41 ` Jeff King
2008-11-02 9:30 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej1w73nr.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).