From: Junio C Hamano <gitster@pobox.com>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Avery Pennarun" <apenwarr@gmail.com>,
git@vger.kernel.org, arman@twinsun.com
Subject: Re: [PATCH] diff: treat -crlf files as binary
Date: Sun, 31 Aug 2008 09:25:17 -0700 [thread overview]
Message-ID: <7vej45b18y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <81b0412b0808310216h6c349e1en740a1f4c7fef75e6@mail.gmail.com> (Alex Riesen's message of "Sun, 31 Aug 2008 11:16:29 +0200")
"Alex Riesen" <raa.lkml@gmail.com> writes:
> 2008/8/30 Junio C Hamano <gitster@pobox.com>:
>> diff --git i/Documentation/gitattributes.txt w/Documentation/gitattributes.txt
>> ...
>> - through line endings conversion upon checkin/checkout.
>> + Unsetting the `crlf` attribute on a path is tells git
>> ...
>
> "+ Unsetting the `crlf` attribute on a path tells git"
>
> (remove "is" before "tells")
Yeah, thanks. I reworded the sentence number of times and somehow crufts
were left behind. Fixed, together with the double space before "upon",
before committing.
I am actually more surprised by the lack of any surprised comment about
the unadvertised presense of "binary" (pseudo)attribute, though. The
support has been there since f48fd68 (attribute macro support,
2007-04-14), two days after introduction of gitattributes mechanism.
Maybe somebody should re-read the log message of that commit, and refine
the attribute macros sections the patch under discussion has added.
Somebody who can write and spell English better than me, that is ;-)
next prev parent reply other threads:[~2008-08-31 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 21:28 [PATCH] diff: treat -crlf files as binary Junio C Hamano
2008-08-29 21:56 ` Avery Pennarun
2008-08-30 21:34 ` Junio C Hamano
2008-08-31 2:34 ` Avery Pennarun
2008-08-31 8:27 ` Matthieu Moy
2008-08-31 9:16 ` Alex Riesen
2008-08-31 16:25 ` Junio C Hamano [this message]
2008-08-31 18:34 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej45b18y.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apenwarr@gmail.com \
--cc=arman@twinsun.com \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).