git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]
@ 2008-07-24  0:22 Junio C Hamano
  2008-07-24  0:58 ` [PATCH] (unnamed) Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2008-07-24  0:22 UTC (permalink / raw)
  To: Nicolas Pitre; +Cc: git

f2eba66 (Enable HEAD@{...} and make it independent from the current
branch, 2007-02-03) introduced dwim_log() to handle <refname>@{...}
syntax, and as part of its processing, it checks if the ref exists by
calling refsolve_ref().  It should call it as a reader to make sure the
call returns NULL for a nonexistent ref (not as a potential writer in
which case it does not return NULL).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * I found this purely by accident.  "echo >.git/logs/refs/heads/HEAD"
   would make your "git rev-parse HEAD@{1}" complain about a refname
   'HEAD' being ambiguous without this patch.

 sha1_name.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sha1_name.c b/sha1_name.c
index b0b2167..4fb77f8 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -273,7 +273,7 @@ int dwim_log(const char *str, int len, unsigned char *sha1, char **log)
 		const char *ref, *it;
 
 		strcpy(path, mkpath(*p, len, str));
-		ref = resolve_ref(path, hash, 0, NULL);
+		ref = resolve_ref(path, hash, 1, NULL);
 		if (!ref)
 			continue;
 		if (!stat(git_path("logs/%s", path), &st) &&

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] (unnamed)
  2008-07-24  0:22 [PATCH] Junio C Hamano
@ 2008-07-24  0:58 ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2008-07-24  0:58 UTC (permalink / raw)
  To: Nicolas Pitre; +Cc: git

Ooops.

I sent out before I can decide what the title should be.  Sorry, will
think of something.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH]
       [not found] <002b01ce1661$245ebb70$6d1c3250$@certicon.cz>
@ 2013-03-01 10:28 ` Jan Pešta
  2013-03-01 11:53   ` [PATCH] Matthieu Moy
  0 siblings, 1 reply; 4+ messages in thread
From: Jan Pešta @ 2013-03-01 10:28 UTC (permalink / raw)
  To: git

Hi,

I found a problem when using GIT-SVN.

In inproperly merges in SVN causes that the ranges contains additional
character "*". 

Attached patch fix this issue, I have it already tested for several months.

Regards,
Jan


Kind regards / S pozdravem
 

Jan Pešta
SW Engineer Sr.

CertiCon a.s., www.certicon.cz
Vaclavska 12
12000 Prague 2
Czech Republic
 
Office Prague: +420 224 904 406
Mobile: +420 604 794 306
 
E-mail: jan.pesta@certicon.cz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]
  2013-03-01 10:28 ` [PATCH] Jan Pešta
@ 2013-03-01 11:53   ` Matthieu Moy
  0 siblings, 0 replies; 4+ messages in thread
From: Matthieu Moy @ 2013-03-01 11:53 UTC (permalink / raw)
  To: Jan Pešta; +Cc: git

Jan Pešta <jan.pesta@certicon.cz> writes:

> Attached patch fix this issue,

Nothing attached, it seems ;-).

Please, read Documentation/SubmittingPatches in Git's source code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-03-01 11:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-24  0:22 [PATCH] Junio C Hamano
2008-07-24  0:58 ` [PATCH] (unnamed) Junio C Hamano
     [not found] <002b01ce1661$245ebb70$6d1c3250$@certicon.cz>
2013-03-01 10:28 ` [PATCH] Jan Pešta
2013-03-01 11:53   ` [PATCH] Matthieu Moy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).