From: Junio C Hamano <gitster@pobox.com>
To: sverre@rabbelier.nl
Cc: namsh@posdata.co.kr, git@vger.kernel.org
Subject: Re: [PATCH] Use SHELL_PATH
Date: Wed, 16 Jul 2008 09:05:33 -0700 [thread overview]
Message-ID: <7vej5tu84y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vr69tu91e.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 16 Jul 2008 08:46:05 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> It wants to make sure that the shell specified from the toplevel Makefile
> (or from make command line) is used to run the aggregation script. It is
> often necessary when platform /bin/sh is not quite POSIX (e.g. the script
> in question uses arithmetic expansion "$(( $var1 + $var2 ))").
>
> Just saying "Use specified shell to run shell scripts" on the title line
> would be sufficient, but I wonder if this is the only remaining place...
People on funny platforms might find this one useful, which is consistent
with the way the patch under discussion called the shell. This lets you
to say
SHELL_PATH = /Program Files/GNU/Bash
or something silly like that ;-)
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 9b52071..a2b2627 100644
--- a/Makefile
+++ b/Makefile
@@ -153,7 +153,7 @@ all::
# broken, or spawning external process is slower than built-in grep git has).
GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
- @$(SHELL_PATH) ./GIT-VERSION-GEN
+ @'$(SHELL_PATH_SQ)' ./GIT-VERSION-GEN
-include GIT-VERSION-FILE
uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
next prev parent reply other threads:[~2008-07-16 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 1:31 [PATCH] Use SHELL_PATH SungHyun Nam
2008-07-16 10:47 ` Sverre Rabbelier
2008-07-16 11:00 ` Johannes Schindelin
2008-07-16 15:46 ` Junio C Hamano
2008-07-16 16:05 ` Junio C Hamano [this message]
2008-07-17 0:32 ` SungHyun Nam
2008-07-17 0:38 ` SungHyun Nam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej5tu84y.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=namsh@posdata.co.kr \
--cc=sverre@rabbelier.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).