From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix http-push test
Date: Mon, 07 Jul 2008 12:54:41 -0700 [thread overview]
Message-ID: <7vej6531xa.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080707190847.GA24489@glandium.org> (Mike Hommey's message of "Mon, 7 Jul 2008 21:08:47 +0200")
Mike Hommey <mh@glandium.org> writes:
> On Mon, Jul 07, 2008 at 09:02:37PM +0200, Mike Hommey wrote:
>> http-push test has been broken by 4a7aaccd adding a space character
>> in the place where the test is being run.
>> ---
>>
>> Note that the 4th test doesn't pass because of the new git clone, that
>> creates the clone with packed-refs instead of refs/heads/master that
>> push is requiring. But this also means push was already broken with
>> repositories with packed-refs.
>
> Actually, the 3rd is failing too, but fails to report an error because
> git push returns no error code in cases where it says:
> No refs in common and none specified; doing nothing.
Ok, when you are done checking, care to send in a replacement patch with
failing one marked with test_expect_failure?
You do not have to hurry, I am currently at day job and already deep in
today's integration cycle during the lunchtime, and won't be able to queue
new fixes for several hours from now, so your patch will be part of
tomorrow's or tonight's cycle anyway.
next prev parent reply other threads:[~2008-07-07 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 19:02 [PATCH] Fix http-push test Mike Hommey
2008-07-07 19:08 ` Mike Hommey
2008-07-07 19:54 ` Junio C Hamano [this message]
2008-07-07 20:17 ` Mike Hommey
2008-07-07 21:06 ` [PATCH] Catch failures from t5540-http-push Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej6531xa.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).