From: Junio C Hamano <gitster@pobox.com>
To: "Sverre Rabbelier" <srabbelier@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jakub Narebski" <jnareb@gmail.com>,
"Git list" <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results
Date: Sun, 08 Jun 2008 13:59:28 -0700 [thread overview]
Message-ID: <7vej77iqxb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: bd6139dc0806081202l48953181q7d337455c85bbe2c@mail.gmail.com
"Sverre Rabbelier" <srabbelier@gmail.com> writes:
> Ah, I guess logging to /tmp/git-test-result was more reliable then.
> Any suggestions as to what is the best solution here? (We could for
> example save $PWD at the beginning of test-lib.sh.)
Saving at the beginning to use in test_done, and optionally detecting
that cwd was changed and warn, would be sensible, I think.
> Ah, yes, I was going to have each test log to their own file
> (test-results-$$) and then cat the result together, but I figured that
> since we are .NOTPARALLEL anyway it would be more efficient not to. I
> reckon that whenever we decide to make such a change it will be then
> that we modify this script, if it is included?
Yup. That is what I meant by "not immediate, but something to keep in
mind".
next prev parent reply other threads:[~2008-06-08 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 14:04 [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results Sverre Rabbelier
2008-06-08 14:04 ` [PATCH 2/3] A simple script to parse the results from the testcases Sverre Rabbelier
2008-06-08 14:04 ` [PATCH 3/3] Hook up the result aggregation in the test makefile Sverre Rabbelier
2008-06-08 14:42 ` [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results Jakub Narebski
2008-06-08 14:45 ` Sverre Rabbelier
2008-06-08 18:53 ` Junio C Hamano
2008-06-08 19:02 ` Sverre Rabbelier
2008-06-08 20:59 ` Junio C Hamano [this message]
2008-06-09 0:44 ` [PATCH 4/4] Make test-lib warn if the directory changes Sverre Rabbelier
-- strict thread matches above, loose matches on Subject: below --
2008-05-12 9:33 [PATCH 0/3] Aggregate testcase results Sverre Rabbelier
2008-05-12 9:33 ` [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results Sverre Rabbelier
2008-05-12 14:55 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej77iqxb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).