From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add color.diff.{header,message} formats
Date: Sat, 17 May 2008 11:17:03 -0700 [thread overview]
Message-ID: <7vej80dcdc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080517130739.GA2326@artemis.madism.org> (Pierre Habouzit's message of "Sat, 17 May 2008 15:07:39 +0200")
Pierre Habouzit <madcoder@debian.org> writes:
> Hmmm it seems this patch has been somehow lost somewhere, is there
> anything wrong with it ?
It may not break anything, and I did not hear anybody on the list who said
this breaks soemthing. But I did not hear anybody on the list who wanted
to have this except you, either. At this stage of development, the
question we should be asking is not if there is anything wrong with it,
but if there is anything _good_ with it.
It looks rather widespread compared to a perceived benefit. Perhaps after
a refactoring to make the parameter to pretty-print-commit a bit more
easily extensible, the patch might start looking more promising. I dunno.
next prev parent reply other threads:[~2008-05-17 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 9:38 [PATCH] Add color.diff.{header,message} formats Pierre Habouzit
2008-05-17 13:07 ` Pierre Habouzit
2008-05-17 18:17 ` Junio C Hamano [this message]
2008-05-17 18:34 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej80dcdc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).