From: Junio C Hamano <gitster@pobox.com>
To: "Govind Salinas" <govind@sophiasuchtig.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] pretty.c: add %z specifier.
Date: Thu, 20 Mar 2008 21:48:16 -0700 [thread overview]
Message-ID: <7veja4u1gv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <5d46db230803201745mb736e98w4925e14b5d92d71d@mail.gmail.com> (Govind Salinas's message of "Thu, 20 Mar 2008 19:45:26 -0500")
"Govind Salinas" <govind@sophiasuchtig.com> writes:
> diff --git a/pretty.c b/pretty.c
> index 703f521..fd155ec 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -478,6 +478,9 @@ static size_t format_commit_item(struct strbuf
> *sb, const char *placeholder,
> case 'n': /* newline */
> strbuf_addch(sb, '\n');
> return 1;
> + case 'z': /* null */
> + strbuf_addch(sb, '\0');
> + return 1;
> }
>
> /* these depend on the commit */
I do not like this at all. Why aren't we doing %XX (2 hexadecimal digits
for an octet)?
next prev parent reply other threads:[~2008-03-21 4:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 0:45 [PATCH] pretty.c: add %z specifier Govind Salinas
2008-03-21 2:13 ` Jeff King
2008-03-21 4:48 ` Junio C Hamano [this message]
2008-03-21 4:51 ` Jeff King
2008-03-21 5:09 ` Junio C Hamano
2008-03-21 5:42 ` Govind Salinas
2008-03-21 5:50 ` David Symonds
2008-03-21 6:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veja4u1gv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=govind@sophiasuchtig.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).