From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix Date: Wed, 16 Jan 2008 17:19:37 -0800 Message-ID: <7vejchmeom.fsf@gitster.siamese.dyndns.org> References: <7vhched3kw.fsf@gitster.siamese.dyndns.org> <7v4pded1rk.fsf_-_@gitster.siamese.dyndns.org> <7v7iiabjyh.fsf_-_@gitster.siamese.dyndns.org> <7v1w8hploy.fsf@gitster.siamese.dyndns.org> <7vprw1mfpr.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Barkalow , Linus Torvalds , Chris Ortman , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Thu Jan 17 02:20:40 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JFJQt-0001PM-S6 for gcvg-git-2@gmane.org; Thu, 17 Jan 2008 02:20:40 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750943AbYAQBUL (ORCPT ); Wed, 16 Jan 2008 20:20:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750958AbYAQBUL (ORCPT ); Wed, 16 Jan 2008 20:20:11 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:48146 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbYAQBUJ (ORCPT ); Wed, 16 Jan 2008 20:20:09 -0500 Received: from a-sasl-quonix (localhost [127.0.0.1]) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id 4F5394D29; Wed, 16 Jan 2008 20:20:07 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id 4A3A84D28; Wed, 16 Jan 2008 20:19:59 -0500 (EST) In-Reply-To: (Johannes Schindelin's message of "Thu, 17 Jan 2008 01:11:16 +0000 (GMT)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: > Having had time to think about it for a while, I think that the > --no-prefix still can make sense with --git. For example, if I want to > submit a gitk patch, but only have git.git (and consequently, made the fix > in that repository), I could use "git diff --no-prefix" to make it easier > for Paul, no? No, what you are talking about is a need of negative prefix, which you did not implement in that no/src/dst-prefix patch. Using --no-prefix is a _hack_ that may happen to work only when the subtree-merged project is one level down. You would need negative prefix of two level _and_ a/ and b/ prefix, when gitk is moved to modules/gitk subdirectory. Incidentally I am planning to do such a move of gitk and git-gui to one level down (modules/gitk and modules/git-gui) sometime in the future when I convert git.git to use submodules. Privately I already have such a tree based on -rc3 but for obvious reasons I cannot push it out even to a preview branch in git.git repository for the time being.