From: Junio C Hamano <gitster@pobox.com>
To: Jim Meyering <jim@meyering.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git list <git@vger.kernel.org>
Subject: Re: [PATCH] bundle, fast-import: detect write failure
Date: Thu, 10 Jan 2008 23:36:46 -0800 [thread overview]
Message-ID: <7vejco4xv5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87hchlhm3k.fsf@rho.meyering.net> (Jim Meyering's message of "Thu, 10 Jan 2008 14:00:15 +0100")
Jim Meyering <jim@meyering.net> writes:
> On the other hand, if that write failure is truly ignorable,
> a mindless minimalist :-) might argue that it's best just to
> omit the syscall.
Usually the contents of .keep file is a small one-line comment
that describes who decided that the pack needs to be kept and
why, so the answer is no.
In this case, a failure while closing that small .keep file is
highly unlikely, and if we ever mange to trigger such a highly
unlikely failure, I think we would rather want to *know* about
it, as it is likely there is something more seriously wrong
going on.
So let's keep that check on close().
next prev parent reply other threads:[~2008-01-11 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 8:54 [PATCH] bundle, fast-import: detect write failure Jim Meyering
2008-01-10 9:17 ` Pierre Habouzit
2008-01-10 12:05 ` Johannes Schindelin
2008-01-10 12:26 ` Jim Meyering
2008-01-10 12:37 ` Johannes Schindelin
2008-01-10 13:00 ` Jim Meyering
2008-01-10 16:25 ` Pierre Habouzit
2008-01-10 18:05 ` Jim Meyering
2008-01-10 18:18 ` Pierre Habouzit
2008-01-11 9:14 ` Jakub Narebski
2008-01-11 7:36 ` Junio C Hamano [this message]
2008-01-11 9:37 ` David Tweed
2008-01-11 11:39 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vejco4xv5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).